[heap] Remove black pages and use black areas instead.

src/heap/mark-compact-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HEAP_MARK_COMPACT_INL_H_
 #define V8_HEAP_MARK_COMPACT_INL_H_
 
 #include "src/heap/mark-compact.h"
 #include "src/heap/remembered-set.h"
 #include "src/isolate.h"
@@ skipping 135 matching lines @@
         second_bit_index = 1u << (trailing_zeros + 1);
       } else {
         second_bit_index = 0x1;
         // The overlapping case; there has to exist a cell after the current
         // cell.
         DCHECK(!it_.Done());
         it_.Advance();
         cell_base_ = it_.CurrentCellBase();
         current_cell_ = *it_.CurrentCell();
       }
-      if (T == kBlackObjects && (current_cell_ & second_bit_index)) {
-        object = HeapObject::FromAddress(addr);
-      } else if (T == kGreyObjects && !(current_cell_ & second_bit_index)) {
-        object = HeapObject::FromAddress(addr);
-      } else if (T == kAllLiveObjects) {
+
+      if (current_cell_ & second_bit_index) {
+        // We found a black object. If the black object is within a black area,
+        // make sure that we skip all set bits in the black area until the
+        // object ends.
+        HeapObject* black_object = HeapObject::FromAddress(addr);
+        Address end = addr + black_object->Size() - kPointerSize;
+        MemoryChunk* chunk = MemoryChunk::FromAddress(end);

[ulan, 2016/07/19 13:23:32]

DCHECK_EQ(chunk_, MemoryChunk::FromAddress(end));
and use chunk_ instead of chunk

[Hannes Payer (out of office), 2016/07/19 14:42:53]

Done.

+        uint32_t end_mark_bit_index = chunk->AddressToMarkbitIndex(end);
+        unsigned int end_cell_index =
+            end_mark_bit_index >> Bitmap::kBitsPerCellLog2;
+        MarkBit::CellType end_index_mask =
+            1u << Bitmap::IndexInCell(end_mark_bit_index);
+        if (it_.Advance(end_cell_index)) {
+          cell_base_ = it_.CurrentCellBase();
+          current_cell_ = *it_.CurrentCell();
+        }

[ulan, 2016/07/19 13:23:32]

Let's add a comment, something like: Clear all bits in the cell up to and
including the end.

[Hannes Payer (out of office), 2016/07/19 14:42:53]

Done.

+        current_cell_ &= ~(end_index_mask + end_index_mask - 1);
+
+        if (T == kBlackObjects || T == kAllLiveObjects) {
+          object = black_object;
+        }
+      } else if ((T == kGreyObjects || T == kAllLiveObjects)) {
         object = HeapObject::FromAddress(addr);
       }
 
-      // Clear the second bit of the found object.
-      current_cell_ &= ~second_bit_index;
-
       // We found a live object.
       if (object != nullptr) break;
     }
+
     if (current_cell_ == 0) {
       if (!it_.Done()) {
         it_.Advance();
         cell_base_ = it_.CurrentCellBase();
         current_cell_ = *it_.CurrentCell();
       }
     }
     if (object != nullptr) return object;
   }
   return nullptr;
 }
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_HEAP_MARK_COMPACT_INL_H_