Introduce parent ScopeState class and track the scope through the state in the parser

Introduce parent ScopeState class and track the scope through the state in the parser

This will allow us to move more state from Scope into ScopeState and lazily allocate full Scopes only when needed.

BUG=v8:5209
Committed: https://crrev.com/4f552f5a17913385075e595310ddec9de87b3106
Cr-Commit-Position: refs/heads/master@{#37858}

[Toon Verwaest, 2016-07-18 14:26:58]

verwaest@chromium.org changed reviewers:
+ marja@chromium.org

[Toon Verwaest, 2016-07-18 14:26:58]

ptal

[adamk, 2016-07-18 17:14:44]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-07-18 17:14:45]

https://codereview.chromium.org/2160593002/diff/40001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2160593002/diff/40001/src/parsing/parser-base...
src/parsing/parser-base.h:253: // FunctionState and BlockState together
implement the parser's scope stack.
Please update this comment to explain what ScopeState is for.

https://codereview.chromium.org/2160593002/diff/40001/src/parsing/parser-base...
src/parsing/parser-base.h:1179: inline Scope* scope() const { return
state_->scope(); }
No need for these "inline"s, unless you want to V8_INLINE?

https://codereview.chromium.org/2160593002/diff/40001/src/parsing/parser-base...
src/parsing/parser-base.h:1181: ScopeState* state_;              // Scope stack.
scope_state_ seems like the right name here, at least for now.

[adamk, 2016-07-18 17:33:01]

I would also find it really useful if this had a tracking bug associated with it
(and, ideally, a design sketch linked from there), as it seems to be the first
part of a possibly-major refactoring.

[marja, 2016-07-19 07:54:42]

+1 to adamk@'s comments

lgtm from my side, assuming you do the changes he suggested.

https://codereview.chromium.org/2160593002/diff/40001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2160593002/diff/40001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1242: if (!this->scope()->HasSimpleParameters()) {
(Style) Why so much "this->"? Afaics it's only needed inside the template
classes but not here.

[Toon Verwaest, 2016-07-19 09:27:04]

Description was changed from

==========
Introduce parent ScopeState class and track the scope through the state in the
parser

This will allow us to move more state from Scope into ScopeState and lazily
allocate full Scopes only when needed.

BUG=
==========

to

==========
Introduce parent ScopeState class and track the scope through the state in the
parser

This will allow us to move more state from Scope into ScopeState and lazily
allocate full Scopes only when needed.

BUG=v8:5209
==========

[Toon Verwaest, 2016-07-19 09:36:47]

Addressed comments.

this->scope() I used whenever there was another local variable called scope. I
think that's a little better than coming up with a random renaming for the local
scope variable. As we reduce eager allocation of local Scope objects, we can
likely turn this back into a regular scope().

[Toon Verwaest, 2016-07-19 09:44:01]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-07-19 09:44:01]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2160593002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-19 09:44:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 10:06:45]

Description was changed from

==========
Introduce parent ScopeState class and track the scope through the state in the
parser

This will allow us to move more state from Scope into ScopeState and lazily
allocate full Scopes only when needed.

BUG=v8:5209
==========

to

==========
Introduce parent ScopeState class and track the scope through the state in the
parser

This will allow us to move more state from Scope into ScopeState and lazily
allocate full Scopes only when needed.

BUG=v8:5209
==========

[commit-bot: I haz the power, 2016-07-19 10:06:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-19 10:08:19]

Description was changed from

==========
Introduce parent ScopeState class and track the scope through the state in the
parser

This will allow us to move more state from Scope into ScopeState and lazily
allocate full Scopes only when needed.

BUG=v8:5209
==========

to

==========
Introduce parent ScopeState class and track the scope through the state in the
parser

This will allow us to move more state from Scope into ScopeState and lazily
allocate full Scopes only when needed.

BUG=v8:5209

Committed: https://crrev.com/4f552f5a17913385075e595310ddec9de87b3106
Cr-Commit-Position: refs/heads/master@{#37858}
==========

[commit-bot: I haz the power, 2016-07-19 10:08:20]

Patchset 5 (id:??) landed as
https://crrev.com/4f552f5a17913385075e595310ddec9de87b3106
Cr-Commit-Position: refs/heads/master@{#37858}