Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2160583002: Add filename to gradient scrape (Closed)

Created:
4 years, 5 months ago by fmenozzi
Modified:
4 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix line length problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M tools/lua/gradients.lua View 3 chunks +13 lines, -3 lines 0 comments Download
M tools/lua/gradients.py View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
fmenozzi
ptal
4 years, 5 months ago (2016-07-18 13:50:47 UTC) #3
reed1
lgtm
4 years, 5 months ago (2016-07-18 14:15:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160583002/1
4 years, 5 months ago (2016-07-18 14:37:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/11355)
4 years, 5 months ago (2016-07-18 14:39:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160583002/20001
4 years, 5 months ago (2016-07-18 14:44:00 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 15:20:10 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f023e6879c63e5d223e89707a714f18688a93a4a

Powered by Google App Engine
This is Rietveld 408576698