Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/gn/target.cc

Issue 2160533004: Revert of [GN] Add JSON project writer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/json_project_writer.cc ('k') | tools/gn/visibility.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index 591062e4840e3f1bc751616c213784c17f9922a1..85955a7168fb371ffea80321bcf8c6c777d4e597 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -14,7 +14,6 @@
#include "tools/gn/config_values_extractors.h"
#include "tools/gn/deps_iterator.h"
#include "tools/gn/filesystem_utils.h"
-#include "tools/gn/functions.h"
#include "tools/gn/scheduler.h"
#include "tools/gn/source_file_type.h"
#include "tools/gn/substitution_writer.h"
@@ -216,29 +215,29 @@
const char* Target::GetStringForOutputType(OutputType type) {
switch (type) {
case UNKNOWN:
- return "unknown";
+ return "Unknown";
case GROUP:
- return functions::kGroup;
+ return "Group";
case EXECUTABLE:
- return functions::kExecutable;
+ return "Executable";
case LOADABLE_MODULE:
- return functions::kLoadableModule;
+ return "Loadable module";
case SHARED_LIBRARY:
- return functions::kSharedLibrary;
+ return "Shared library";
case STATIC_LIBRARY:
- return functions::kStaticLibrary;
+ return "Static library";
case SOURCE_SET:
- return functions::kSourceSet;
+ return "Source set";
case COPY_FILES:
- return functions::kCopy;
+ return "Copy";
case ACTION:
- return functions::kAction;
+ return "Action";
case ACTION_FOREACH:
- return functions::kActionForEach;
+ return "ActionForEach";
case BUNDLE_DATA:
- return functions::kBundleData;
+ return "Bundle data";
case CREATE_BUNDLE:
- return functions::kCreateBundle;
+ return "Create bundle";
default:
return "";
}
« no previous file with comments | « tools/gn/json_project_writer.cc ('k') | tools/gn/visibility.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698