Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2160533003: MIPS: Fix deoptimization failure in WordCompare (Closed)

Created:
4 years, 5 months ago by ivica.bogosavljevic
Modified:
4 years, 5 months ago
Reviewers:
v8-mips-ports, balazs.kilvady, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix deoptimization failure in WordCompare In case of deoptimization after WordCompare test, the control flow is lost in the unoptimized version of the code because wrong register is used for comparision (a0 instead of v0) TEST=mjsunit/regress/regress-3717 BUG= Committed: https://crrev.com/4d0c8c77140b077c4530fc5e6b623f9516b61af3 Cr-Commit-Position: refs/heads/master@{#37845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
ivica.bogosavljevic
PTAL One line fix
4 years, 5 months ago (2016-07-18 19:26:43 UTC) #2
akos.palfi.imgtec
LGTM.
4 years, 5 months ago (2016-07-18 19:42:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160533003/1
4 years, 5 months ago (2016-07-18 20:04:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 20:29:01 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 20:32:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d0c8c77140b077c4530fc5e6b623f9516b61af3
Cr-Commit-Position: refs/heads/master@{#37845}

Powered by Google App Engine
This is Rietveld 408576698