Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2160533002: Add use counters for Secure Context checks and sandboxed origins. (Closed)

Created:
4 years, 5 months ago by Mike West
Modified:
4 years, 5 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counters for Secure Context checks and sandboxed origins. At https://github.com/w3c/webappsec-secure-contexts/issues/28, we're discussing whether or not we can tighten the notion of "secure context" to exclude sandboxed documents by default. This patch adds counters to determine how marginal the breakage would be. BUG=534788 TBR=isherman@chromium.org Committed: https://crrev.com/ea6225bf8fb44062eabe9e9c99527408053180dd Cr-Commit-Position: refs/heads/master@{#405973}

Patch Set 1 #

Patch Set 2 : Wrong flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +22 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Mike West
Jochen, mind taking a look?
4 years, 5 months ago (2016-07-18 08:41:29 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-18 08:45:49 UTC) #5
Mike West
TBRing Ilya for the mechanical change to `histograms.xml`. Hi, Ilya!
4 years, 5 months ago (2016-07-18 09:17:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160533002/20001
4 years, 5 months ago (2016-07-18 09:18:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 10:44:14 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ea6225bf8fb44062eabe9e9c99527408053180dd Cr-Commit-Position: refs/heads/master@{#405973}
4 years, 5 months ago (2016-07-18 10:46:24 UTC) #13
Ilya Sherman
4 years, 5 months ago (2016-07-18 22:54:49 UTC) #14
Message was sent while issue was closed.
histograms.xml lgtm

Powered by Google App Engine
This is Rietveld 408576698