Files.app multi-profile: add back migration to old path format.

Files.app multi-profile: add back migration to old path format.

This CL adds Download folder path migration from /home/chronos/u-hash/Downloads
to /home/chronos/user/Downloads when in the current running environment the
profile path is set as the latter. It can happen when (1) the user enabled and
then disabled the multi-profile flag, or (2) performed restart from about:flags.
In such situations we need back migration not to break configurations.

In addition, inserted path convertion to public functions in open_util so that
paths stored in download history (during flipped path due to about:flags) can
be correctly handled.

BUG=356322, 329744
R=hirono@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260092

[hirono, 2014-03-28 02:05:35]

lgtm with two nits.

https://codereview.chromium.org/216053002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_manager/path_util.cc (right):

https://codereview.chromium.org/216053002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_manager/path_util.cc:75: const chromeos::User* user
=
nit: const chromeos::User* const user

https://codereview.chromium.org/216053002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_manager/path_util.cc:78: base::FilePath
hashed_downloads =
nit: const base::FilePath

[kinaba, 2014-03-28 02:11:06]

https://codereview.chromium.org/216053002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_manager/path_util.cc (right):

https://codereview.chromium.org/216053002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_manager/path_util.cc:75: const chromeos::User* user
=
On 2014/03/28 02:05:35, hirono wrote:
> nit: const chromeos::User* const user

Done.

https://codereview.chromium.org/216053002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_manager/path_util.cc:78: base::FilePath
hashed_downloads =
On 2014/03/28 02:05:35, hirono wrote:
> nit: const base::FilePath

Done.

[kinaba, 2014-03-28 02:19:03]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-03-28 02:27:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/216053002/20001

[commit-bot: I haz the power, 2014-03-28 03:10:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 03:10:20]

Retried try job too often on ios_dbg_simulator for step(s) url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[kinaba, 2014-03-28 03:18:42]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-03-28 03:19:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/216053002/20001

[commit-bot: I haz the power, 2014-03-28 03:52:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 03:52:42]

Retried try job too often on ios_dbg_simulator for step(s) sql_unittests,
ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[kinaba, 2014-03-28 04:14:06]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-03-28 04:16:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/216053002/20001

[commit-bot: I haz the power, 2014-03-28 07:01:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 07:02:00]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[kinaba, 2014-03-28 07:04:55]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-03-28 07:06:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/216053002/20001

[kinaba, 2014-03-28 08:54:20]

Committed patchset #2 manually as r260092 (presubmit successful).