Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1993)

Issue 2160523002: Send UpdateState when detaching a RenderFrame in FNE-enabled modes. (Closed)

Created:
4 years, 5 months ago by Charlie Reis
Modified:
4 years, 5 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send UpdateState when detaching a RenderFrame in FNE-enabled modes. This ensures we do not lose PageState when navigating the main frame, at least in the same-process navigation case. BUG= TEST= Committed: https://crrev.com/9feb2eaa8138de7d6bd4014e449abd4ba009fc34 Cr-Commit-Position: refs/heads/master@{#406589}

Patch Set 1 #

Patch Set 2 : Move fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/renderer/render_frame_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/isolate-extensions View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Charlie Reis
Nasko, can you take a look? This resolves one of the navigation layout tests, where ...
4 years, 5 months ago (2016-07-20 16:43:20 UTC) #10
nasko
LGTM
4 years, 5 months ago (2016-07-20 16:51:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160523002/20001
4 years, 5 months ago (2016-07-20 16:53:39 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 16:59:29 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 16:59:39 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 17:01:14 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9feb2eaa8138de7d6bd4014e449abd4ba009fc34
Cr-Commit-Position: refs/heads/master@{#406589}

Powered by Google App Engine
This is Rietveld 408576698