Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Unified Diff: chrome/browser/installable/installable_logging.h

Issue 2160513002: Extract AppBannerDataFetcher into an InstallableManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_logging.h
diff --git a/chrome/browser/installable/installable_logging.h b/chrome/browser/installable/installable_logging.h
new file mode 100644
index 0000000000000000000000000000000000000000..766287abfed8629517c66fdd54904c7c2ccbc437
--- /dev/null
+++ b/chrome/browser/installable/installable_logging.h
@@ -0,0 +1,50 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_
+#define CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_
+
+#include <string>
+
+namespace content {
+class WebContents;
+}
+
+// These values are a central reference for installability errors. The
+// InstallableManager will specify an InstallableErrorCode (or
+// NO_ERROR_DETECTED) in its result. Clients may also add their own error codes
+// to this list, and utilise LogErrorToConsole to write a message to the
+// devtools console.
+// TODO(dominickn) add an UMA metric for this enum.
+enum InstallableErrorCode {
+ NO_ERROR_DETECTED,
+ RENDERER_EXITING,
+ RENDERER_CANCELLED,
+ USER_NAVIGATED,
+ NOT_IN_MAIN_FRAME,
+ NOT_FROM_SECURE_ORIGIN,
+ NO_MANIFEST,
+ MANIFEST_EMPTY,
+ START_URL_NOT_VALID,
+ MANIFEST_MISSING_NAME_OR_SHORT_NAME,
+ MANIFEST_DISPLAY_NOT_SUPPORTED,
+ MANIFEST_MISSING_SUITABLE_ICON,
+ NO_MATCHING_SERVICE_WORKER,
+ NO_ACCEPTABLE_ICON,
+ CANNOT_DOWNLOAD_ICON,
+ NO_ICON_AVAILABLE,
+ PLATFORM_NOT_SUPPORTED_ON_ANDROID,
+ NO_ID_SPECIFIED,
+ IDS_DO_NOT_MATCH,
+ MAX_ERROR_CODE,
+};
+
+// Logs a message associated with |code| with a parameter |param| to the
+// devtools console attached to |web_contents|. Does nothing if |web_contents|
+// is nullptr.
+void LogErrorToConsole(content::WebContents* web_contents,
+ InstallableErrorCode code,
+ const std::string& param);
+
+#endif // CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_

Powered by Google App Engine
This is Rietveld 408576698