Issue 2160473002: Don't allow deferred frames to create new windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2160473002: Don't allow deferred frames to create new windows. (Closed)

Created:
4 years, 5 months ago by kinuko

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Don't allow deferred frames to create new windows. New pages never defer loads, which makes it difficult for ScopedPageLoadDeferrer to protect against synchronous loads. This patch adds a check in ChromeClientImpl::createWindow. BUG=616907 Review-Url: https://codereview.chromium.org/2035973002 Cr-Commit-Position: refs/heads/master@{#403640} (cherry picked from commit 25a8ae78165cd8725465d26e02a342d7121c42f4) Committed: https://chromium.googlesource.com/chromium/src/+/cbe0b97d5cf56f8eaab3b2fc57b925c69d8f7aa0

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/web/ChromeClientImpl.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp	View		3 chunks	+46 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

kinuko

4 years, 5 months ago (2016-07-17 10:16:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cbe0b97d5cf56f8eaab3b2fc57b925c69d8f7aa0.