Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2160423002:
Fix search always navigating to quick unlock authenticate screen. (Closed)
|
Created:
4 years, 5 months ago by jdufault Modified:
4 years, 5 months ago Reviewers:
tommycli CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix search always navigating to quick unlock authenticate screen.
BUG=629598
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/611982bedb154c8f6138d7bb881047520940919a
Cr-Commit-Position: refs/heads/master@{#406617}
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
Description was changed from ========== Fix search always navigating to quick unlock authenticate screen. BUG=629598 ========== to ========== Fix search always navigating to quick unlock authenticate screen. BUG=629598 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
Description was changed from ========== Fix search always navigating to quick unlock authenticate screen. BUG=629598 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix search always navigating to quick unlock authenticate screen. BUG=629598 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
jdufault@chromium.org changed reviewers: + tommycli@chromium.org
Tommy, PTAL. Thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm thanks!
The CQ bit was unchecked by jdufault@chromium.org
The CQ bit was checked by jdufault@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jdufault@chromium.org
PTAL again, thanks! https://codereview.chromium.org/2160423002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.js (right): https://codereview.chromium.org/2160423002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.js:106: this.resetState_(); I could also implement attached as attached: function() { this.onRouteChanged_(this.currentRoute, this.currentRoute); }
https://codereview.chromium.org/2160423002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js (right): https://codereview.chromium.org/2160423002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js:97: // some initializing order issues handling it here. Hmm.. it would be good to be able to call out exactly what the initializing order issue is. https://codereview.chromium.org/2160423002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.js (right): https://codereview.chromium.org/2160423002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.js:127: this.resetState_(); Is it intentional that this is no longer within the else block?
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by jdufault@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix search always navigating to quick unlock authenticate screen. BUG=629598 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix search always navigating to quick unlock authenticate screen. BUG=629598 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Fix search always navigating to quick unlock authenticate screen. BUG=629598 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix search always navigating to quick unlock authenticate screen. BUG=629598 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/611982bedb154c8f6138d7bb881047520940919a Cr-Commit-Position: refs/heads/master@{#406617} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/611982bedb154c8f6138d7bb881047520940919a Cr-Commit-Position: refs/heads/master@{#406617} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
