Chromium Code Reviews

Side by Side Diff: src/processor/minidump_processor.cc

Issue 2160373002: Add new exception code for OOM generated from Chromium. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 // Copyright (c) 2006, Google Inc. 1 // Copyright (c) 2006, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 1168 matching lines...)
1179 break; 1179 break;
1180 case MD_EXCEPTION_CODE_WIN_POSSIBLE_DEADLOCK: 1180 case MD_EXCEPTION_CODE_WIN_POSSIBLE_DEADLOCK:
1181 reason = "EXCEPTION_POSSIBLE_DEADLOCK"; 1181 reason = "EXCEPTION_POSSIBLE_DEADLOCK";
1182 break; 1182 break;
1183 case MD_EXCEPTION_CODE_WIN_STACK_BUFFER_OVERRUN: 1183 case MD_EXCEPTION_CODE_WIN_STACK_BUFFER_OVERRUN:
1184 reason = "EXCEPTION_STACK_BUFFER_OVERRUN"; 1184 reason = "EXCEPTION_STACK_BUFFER_OVERRUN";
1185 break; 1185 break;
1186 case MD_EXCEPTION_CODE_WIN_HEAP_CORRUPTION: 1186 case MD_EXCEPTION_CODE_WIN_HEAP_CORRUPTION:
1187 reason = "EXCEPTION_HEAP_CORRUPTION"; 1187 reason = "EXCEPTION_HEAP_CORRUPTION";
1188 break; 1188 break;
1189 case MD_EXCEPTION_OUT_OF_MEMORY:
1190 reason = "EXCEPTION_OUT_OF_MEMORY";
Mark Mentovai 2016/07/19 20:30:50 This makes it sound like it’s a constant from the
Will Harris 2016/07/19 21:30:35 yes I agree, I've changed this to "Out of Memory".
1191 break;
1189 case MD_EXCEPTION_CODE_WIN_UNHANDLED_CPP_EXCEPTION: 1192 case MD_EXCEPTION_CODE_WIN_UNHANDLED_CPP_EXCEPTION:
1190 reason = "Unhandled C++ Exception"; 1193 reason = "Unhandled C++ Exception";
1191 break; 1194 break;
1192 default: 1195 default:
1193 BPLOG(INFO) << "Unknown exception reason " << reason; 1196 BPLOG(INFO) << "Unknown exception reason " << reason;
1194 break; 1197 break;
1195 } 1198 }
1196 break; 1199 break;
1197 } 1200 }
1198 1201
(...skipping 366 matching lines...)
1565 char assertion_line[32]; 1568 char assertion_line[32];
1566 snprintf(assertion_line, sizeof(assertion_line), "%u", raw_assertion->line); 1569 snprintf(assertion_line, sizeof(assertion_line), "%u", raw_assertion->line);
1567 assertion_string.append(" at line "); 1570 assertion_string.append(" at line ");
1568 assertion_string.append(assertion_line); 1571 assertion_string.append(assertion_line);
1569 } 1572 }
1570 1573
1571 return assertion_string; 1574 return assertion_string;
1572 } 1575 }
1573 1576
1574 } // namespace google_breakpad 1577 } // namespace google_breakpad
OLDNEW

Powered by Google App Engine