Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2160363003: [css-tables] Mark sibling cells dirty when cell border width changes (Closed)

Created:
4 years, 5 months ago by dgrogan
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-tables] Mark sibling cells dirty when cell border width changes When borders collapse, a cell's border affects its neighbors' widths but we weren't marking widths and needsLayout properly. BUG=613728 Committed: https://crrev.com/a12fde2481d818a6ffcd937f964b4928cf25b9fe Cr-Commit-Position: refs/heads/master@{#406652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -21 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt View 3 chunks +40 lines, -16 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/table/change-cell-border-width.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/table/change-cell-border-width-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 chunk +19 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dgrogan
4 years, 5 months ago (2016-07-20 00:47:59 UTC) #2
eae
LGTM
4 years, 5 months ago (2016-07-20 15:34:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160363003/1
4 years, 5 months ago (2016-07-20 16:50:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/259082)
4 years, 5 months ago (2016-07-20 18:58:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160363003/1
4 years, 5 months ago (2016-07-20 19:05:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 20:20:46 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 20:24:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a12fde2481d818a6ffcd937f964b4928cf25b9fe
Cr-Commit-Position: refs/heads/master@{#406652}

Powered by Google App Engine
This is Rietveld 408576698