Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: tools/mb/mb_config.pyl

Issue 2160353003: Implement multi-phase build support in MB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index 85762e2c0dcdc179b94249800a8b2c7ba9ec7dda..e3c32454b878592f81f979bfdf83692438713f98 100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -109,8 +109,14 @@
'Chromium Mac 10.9 Goma Canary (clobber)': 'gn_release_bot',
'Chromium Mac 10.9 Goma Canary (dbg)': 'gn_debug_bot',
'Chromium Mac 10.9 Goma Canary (dbg)(clobber)': 'gn_debug_bot',
- 'Chromium Win PGO Builder': 'gyp_official_winpgo',
- 'Chromium Win x64 PGO Builder': 'gyp_official_winpgo_x64',
+ 'Chromium Win PGO Builder': [
+ 'gyp_official_chrome_pgo_phase_1_x86',
+ 'gyp_official_chrome_pgo_phase_2_x86'
+ ],
+ 'Chromium Win x64 PGO Builder': [
+ 'gyp_official_chrome_pgo_phase_1_x64',
+ 'gyp_official_chrome_pgo_phase_2_x64',
+ ],
'Chromium Windows Analyze': 'gn_windows_analyze',
'CrWin7Goma': 'gn_release_bot_minimal_symbols_x86',
'CrWin7Goma(clbr)': 'gn_shared_release_bot_minimal_symbols_x86',
@@ -624,9 +630,15 @@
# but it's not clear if that's actually used anywhere.
'win': 'gyp_official',
'win-asan': 'gyp_official_syzyasan',
- 'win-pgo': 'gyp_official_winpgo',
+ 'win-pgo': [
+ 'gyp_official_chrome_pgo_phase_1_x86',
+ 'gyp_official_chrome_pgo_phase_2_x86',
+ ],
'win64': 'gyp_official_x64',
- 'win64-pgo': 'gyp_official_winpgo_x64',
+ 'win64-pgo': [
+ 'gyp_official_chrome_pgo_phase_1_x64',
+ 'gyp_official_chrome_pgo_phase_2_x64',
+ ],
},
'official.desktop.continuous': {
@@ -902,7 +914,10 @@
'win_nacl_sdk_build': 'gyp_release_bot_minimal_symbols_x86',
'win_optional_gpu_tests_rel':
'swarming_gpu_tests_deqp_gles_gn_release_trybot_x86',
- 'win_pgo': 'gyp_official_winpgo',
+ 'win_pgo': [
+ 'gyp_official_chrome_pgo_phase_1_x86',
+ 'gyp_official_chrome_pgo_phase_2_x86',
+ ],
'win_upload_clang': 'gn_release_bot',
'win_chrome_official': 'gn_official_goma_minimal_symbols_x86',
'win_x64_chromium_variable_builder': 'findit',
@@ -1350,14 +1365,20 @@
'gyp', 'official', 'six_concurrent_links',
],
- # TODO(crbug.com/595947) - figure out how to handle PGO, which needs
- # to invoke GYP/GN twice, with two different sets of flags, apparently.
- 'gyp_official_winpgo': [
- 'gyp', 'error',
+ 'gyp_official_chrome_pgo_phase_1_x64': [
+ 'gyp', 'official', 'chrome_pgo_phase_1', 'x64',
+ ],
+
+ 'gyp_official_chrome_pgo_phase_2_x64': [
+ 'gyp', 'official', 'chrome_pgo_phase_2', 'x64',
+ ],
+
+ 'gyp_official_chrome_pgo_phase_1_x86': [
+ 'gyp', 'official', 'chrome_pgo_phase_1', 'x86',
],
- 'gyp_official_winpgo_x64': [
- 'gyp', 'error', 'x64',
+ 'gyp_official_chrome_pgo_phase_2_x86': [
+ 'gyp', 'official', 'chrome_pgo_phase_2', 'x86',
],
'gyp_official_x64': [
@@ -1948,6 +1969,16 @@
'gyp_defines': 'cfi_diag=1',
},
+ 'chrome_pgo_phase_1': {
+ 'gn_args': 'chrome_pgo_phase=1',
+ 'gyp_defines': 'chrome_pgo_phase=1',
+ },
+
+ 'chrome_pgo_phase_2': {
+ 'gn_args': 'chrome_pgo_phase=2',
+ 'gyp_defines': 'chrome_pgo_phase=2',
+ },
+
'chrome_with_codecs': {
'mixins': ['ffmpeg_branding_chrome', 'proprietary_codecs'],
},
« no previous file with comments | « tools/mb/mb.py ('k') | tools/mb/mb_unittest.py » ('j') | tools/mb/mb_unittest.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698