Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: tools/mb/docs/design_spec.md

Issue 2160353003: Implement multi-phase build support in MB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/mb/docs/user_guide.md » ('j') | tools/mb/mb_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/docs/design_spec.md
diff --git a/tools/mb/docs/design_spec.md b/tools/mb/docs/design_spec.md
index f49b9c8c88cc172897ac41067c5537993e4fafaf..33fda806e8abc8e8d45dc20be81d9b18455b830f 100644
--- a/tools/mb/docs/design_spec.md
+++ b/tools/mb/docs/design_spec.md
@@ -46,7 +46,7 @@ with spaces and passed to GYP, or a dict that will be similarly converted),
'mb_type' field that says whether to use GN or GYP. Bot config files
require the full list of settings to be given explicitly.
-If no mathcing bot config file is found, `mb` looks in the
+If no matching bot config file is found, `mb` looks in the
`//tools/mb/mb_config.pyl` config file to determine whether to use GYP or GN
for a particular build directory, and what set of flags (`GYP_DEFINES` or `gn
args`) to use.
@@ -424,16 +424,3 @@ config file change, however.
[CR tool](https://code.google.com/p/chromium/wiki/CRUserManual). Not
only is it only intended to replace the gyp\_chromium part of `'gclient
runhooks'`, it is not really meant as a developer-facing tool.
-
-### Open issues
-
-* Some common flags (goma\_dir being the obvious one) may need to be
- specified via the user, and it's unclear how to integrate this with
- the concept of build\_configs.
-
- Right now, MB has hard-coded support for a few flags (i.e., you can
- pass the --goma-dir flag, and it will know to expand "${goma\_dir}" in
- the string before calling out to the tool. We may want to generalize
- this to a common key/value approach (perhaps then meeting the
- ChromeOS non-goal, above), or we may want to keep this very strictly
- limited for simplicity.
« no previous file with comments | « no previous file | tools/mb/docs/user_guide.md » ('j') | tools/mb/mb_unittest.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698