Implement multi-phase build support in MB.

Implement multi-phase build support in MB.

The PGO builders need to run multiple compiles in a single build,
each with different arguments. This was not previously possible
with MB, but this CL adds support for specifying a list of configs
per builder, and adds a --phase command line arg to indicate which
phase of the build should be generated.

It is an error to specify --phase on a builder that isn't
expected to have multiple phases. Also phases are 1-based (phase 1,
phase 2, etc.).

Also, this CL cleans up some TODOs that I no longer plan to fix.

R=sebmarchand@chromium.org
BUG=595947
Committed: https://crrev.com/b9380a1bd84d8be46835457a9d2a9c004d02e344
Cr-Commit-Position: refs/heads/master@{#406955}

[Dirk Pranke, 2016-07-19 23:14:50]

Patchset #1 (id:1) has been deleted

[Dirk Pranke, 2016-07-19 23:15:53]

Description was changed from

==========
Implement multi-phase build support in MB.

The PGO builders need to run multiple compiles in a single build,
each with different arguments. This was not previously possible
with MB, but this CL adds support for specifying a list of configs
per builder, and adds a --phase command line arg to indicate which
phase of the build should be generated.

It is an error to specify --phase on a builder that isn't
expected to have multiple phases. Also phases are 1-based (phase 1,
phase 2, etc.).

R=sebmarchand@chromium.org
BUG=595947
==========

to

==========
Implement multi-phase build support in MB.

The PGO builders need to run multiple compiles in a single build,
each with different arguments. This was not previously possible
with MB, but this CL adds support for specifying a list of configs
per builder, and adds a --phase command line arg to indicate which
phase of the build should be generated.

It is an error to specify --phase on a builder that isn't
expected to have multiple phases. Also phases are 1-based (phase 1,
phase 2, etc.).

Also, this CL cleans up some TODOs that I no longer plan to fix.

R=sebmarchand@chromium.org
BUG=595947
==========

[Sébastien Marchand, 2016-07-20 12:18:13]

Nice, lgtm ! Thanks !

[Dirk Pranke, 2016-07-21 20:01:25]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-07-21 20:02:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 20:05:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 20:05:07]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Dirk Pranke, 2016-07-21 20:50:55]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-07-21 20:50:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
sebmarchand@chromium.org
Link to the patchset: https://codereview.chromium.org/2160353003/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2016-07-21 20:51:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 21:44:37]

Description was changed from

==========
Implement multi-phase build support in MB.

The PGO builders need to run multiple compiles in a single build,
each with different arguments. This was not previously possible
with MB, but this CL adds support for specifying a list of configs
per builder, and adds a --phase command line arg to indicate which
phase of the build should be generated.

It is an error to specify --phase on a builder that isn't
expected to have multiple phases. Also phases are 1-based (phase 1,
phase 2, etc.).

Also, this CL cleans up some TODOs that I no longer plan to fix.

R=sebmarchand@chromium.org
BUG=595947
==========

to

==========
Implement multi-phase build support in MB.

The PGO builders need to run multiple compiles in a single build,
each with different arguments. This was not previously possible
with MB, but this CL adds support for specifying a list of configs
per builder, and adds a --phase command line arg to indicate which
phase of the build should be generated.

It is an error to specify --phase on a builder that isn't
expected to have multiple phases. Also phases are 1-based (phase 1,
phase 2, etc.).

Also, this CL cleans up some TODOs that I no longer plan to fix.

R=sebmarchand@chromium.org
BUG=595947
==========

[commit-bot: I haz the power, 2016-07-21 21:44:38]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-21 21:46:07]

Description was changed from

==========
Implement multi-phase build support in MB.

The PGO builders need to run multiple compiles in a single build,
each with different arguments. This was not previously possible
with MB, but this CL adds support for specifying a list of configs
per builder, and adds a --phase command line arg to indicate which
phase of the build should be generated.

It is an error to specify --phase on a builder that isn't
expected to have multiple phases. Also phases are 1-based (phase 1,
phase 2, etc.).

Also, this CL cleans up some TODOs that I no longer plan to fix.

R=sebmarchand@chromium.org
BUG=595947
==========

to

==========
Implement multi-phase build support in MB.

The PGO builders need to run multiple compiles in a single build,
each with different arguments. This was not previously possible
with MB, but this CL adds support for specifying a list of configs
per builder, and adds a --phase command line arg to indicate which
phase of the build should be generated.

It is an error to specify --phase on a builder that isn't
expected to have multiple phases. Also phases are 1-based (phase 1,
phase 2, etc.).

Also, this CL cleans up some TODOs that I no longer plan to fix.

R=sebmarchand@chromium.org
BUG=595947

Committed: https://crrev.com/b9380a1bd84d8be46835457a9d2a9c004d02e344
Cr-Commit-Position: refs/heads/master@{#406955}
==========

[commit-bot: I haz the power, 2016-07-21 21:46:08]

Patchset 2 (id:??) landed as
https://crrev.com/b9380a1bd84d8be46835457a9d2a9c004d02e344
Cr-Commit-Position: refs/heads/master@{#406955}

[kjellander_chromium, 2016-12-17 20:55:12]

kjellander@chromium.org changed reviewers:
+ kjellander@chromium.org

[kjellander_chromium, 2016-12-17 20:55:13]

I think I found an error here (when I was looking at our copy).

https://codereview.chromium.org/2160353003/diff/40001/tools/mb/mb_unittest.py
File tools/mb/mb_unittest.py (right):

https://codereview.chromium.org/2160353003/diff/40001/tools/mb/mb_unittest.py...
tools/mb/mb_unittest.py:535: 
What happened here at line 535-557? It seems like a copy-paste error since the
tests are identical and there are two copies of:
if __name__ == '__main__':
  unittest.main()

[Dirk Pranke, 2016-12-18 02:39:46]

https://codereview.chromium.org/2160353003/diff/40001/tools/mb/mb_unittest.py
File tools/mb/mb_unittest.py (right):

https://codereview.chromium.org/2160353003/diff/40001/tools/mb/mb_unittest.py...
tools/mb/mb_unittest.py:535: 
On 2016/12/17 20:55:13, kjellander_chromium wrote:
> What happened here at line 535-557? It seems like a copy-paste error since the
> tests are identical and there are two copies of:
> if __name__ == '__main__':
>   unittest.main()

Whoops. Looks like you're right :).