Added UseCounters for touchstart, mousedown, pointerdown invocation

Added UseCounters for touchstart, mousedown, pointerdown invocation

Also added a PointerEventDispatch counter specific to pointerdowns,
so be able to guess the # of JS-fired events (the difference between
PointerEventDispatchPointerDown & PointerDownFired).

BUG=
TBR=isherman@chromium.org

Committed: https://crrev.com/1f97115c84c175bb4e72d4c4eea6e277b8242b03
Cr-Commit-Position: refs/heads/master@{#406487}

[mustaq, 2016-07-19 19:35:13]

mustaq@chromium.org changed reviewers:
+ dtapuska@chromium.org

[mustaq, 2016-07-19 19:35:13]

ptal

[dtapuska, 2016-07-19 19:43:56]

https://codereview.chromium.org/2160353002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/EventTarget.cpp (right):

https://codereview.chromium.org/2160353002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/EventTarget.cpp:571: if
(static_cast<PointerEvent*>(event)->pointerType() == "touch")
This cast is unsafe. With javascript creating a non pointer event but with type
pointerdown.

[mustaq, 2016-07-19 19:59:07]

ptal

https://codereview.chromium.org/2160353002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/EventTarget.cpp (right):

https://codereview.chromium.org/2160353002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/EventTarget.cpp:571: if
(static_cast<PointerEvent*>(event)->pointerType() == "touch")
On 2016/07/19 19:43:56, dtapuska wrote:
> This cast is unsafe. With javascript creating a non pointer event but with
type
> pointerdown.

Done.

[dtapuska, 2016-07-19 20:01:54]

https://codereview.chromium.org/2160353002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/EventTarget.cpp (right):

https://codereview.chromium.org/2160353002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/EventTarget.cpp:571: if
(toPointerEvent(event)->pointerType() == "touch")
That is now just going to crash the process. I don't think that is good either.

[mustaq, 2016-07-19 20:36:08]

ptal, added PointerEventDispatchPointerDown.

https://codereview.chromium.org/2160353002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/EventTarget.cpp (right):

https://codereview.chromium.org/2160353002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/EventTarget.cpp:571: if
(toPointerEvent(event)->pointerType() == "touch")
On 2016/07/19 20:01:54, dtapuska wrote:
> That is now just going to crash the process. I don't think that is good
either.

Yikes, done.

[mustaq, 2016-07-19 20:39:36]

Description was changed from

==========
Added UseCounters for touchstart, mousedown, pointerdown.

BUG=
==========

to

==========
Added UseCounters for touchstart, mousedown, pointerdown.

Also added a PointerEventDispatch counter specific to pointerdowns,
so be able to guess the # of JS-fired events (the difference between
PointerEventDispatchPointerDown & PointerDownFired).

BUG=
==========

[dtapuska, 2016-07-19 20:45:18]

On 2016/07/19 20:36:08, mustaq wrote:
> ptal, added PointerEventDispatchPointerDown.
> 
>
https://codereview.chromium.org/2160353002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/events/EventTarget.cpp (right):
> 
>
https://codereview.chromium.org/2160353002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/events/EventTarget.cpp:571: if
> (toPointerEvent(event)->pointerType() == "touch")
> On 2016/07/19 20:01:54, dtapuska wrote:
> > That is now just going to crash the process. I don't think that is good
> either.
> 
> Yikes, done.

lgtm

[mustaq, 2016-07-19 20:49:55]

mustaq@chromium.org changed reviewers:
+ bokan@chromium.org, isherman@chromium.org

[mustaq, 2016-07-19 20:49:56]

bokan@chromium.org: Please review changes in Source/core
isherman@chromium.org: Please review changes in metric/histograms

[mustaq, 2016-07-19 21:09:36]

Description was changed from

==========
Added UseCounters for touchstart, mousedown, pointerdown.

Also added a PointerEventDispatch counter specific to pointerdowns,
so be able to guess the # of JS-fired events (the difference between
PointerEventDispatchPointerDown & PointerDownFired).

BUG=
==========

to

==========
Added UseCounters for touchstart, mousedown, pointerdown invocation

Also added a PointerEventDispatch counter specific to pointerdowns,
so be able to guess the # of JS-fired events (the difference between
PointerEventDispatchPointerDown & PointerDownFired).

BUG=
==========

[bokan, 2016-07-19 21:14:20]

Source/core lgtm

[mustaq, 2016-07-19 21:15:43]

Description was changed from

==========
Added UseCounters for touchstart, mousedown, pointerdown invocation

Also added a PointerEventDispatch counter specific to pointerdowns,
so be able to guess the # of JS-fired events (the difference between
PointerEventDispatchPointerDown & PointerDownFired).

BUG=
==========

to

==========
Added UseCounters for touchstart, mousedown, pointerdown invocation

Also added a PointerEventDispatch counter specific to pointerdowns,
so be able to guess the # of JS-fired events (the difference between
PointerEventDispatchPointerDown & PointerDownFired).

BUG=
TBR=isherman@chromium.org
==========

[mustaq, 2016-07-19 21:26:39]

The CQ bit was checked by mustaq@chromium.org

[mustaq, 2016-07-19 21:26:39]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2160353002/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2016-07-19 21:27:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 00:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 00:52:55]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ilya Sherman, 2016-07-20 01:42:32]

histograms.xml lgtm

[mustaq, 2016-07-20 02:33:05]

The CQ bit was checked by mustaq@chromium.org

[commit-bot: I haz the power, 2016-07-20 02:33:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 04:31:16]

Description was changed from

==========
Added UseCounters for touchstart, mousedown, pointerdown invocation

Also added a PointerEventDispatch counter specific to pointerdowns,
so be able to guess the # of JS-fired events (the difference between
PointerEventDispatchPointerDown & PointerDownFired).

BUG=
TBR=isherman@chromium.org
==========

to

==========
Added UseCounters for touchstart, mousedown, pointerdown invocation

Also added a PointerEventDispatch counter specific to pointerdowns,
so be able to guess the # of JS-fired events (the difference between
PointerEventDispatchPointerDown & PointerDownFired).

BUG=
TBR=isherman@chromium.org
==========

[commit-bot: I haz the power, 2016-07-20 04:31:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-20 04:33:03]

Description was changed from

==========
Added UseCounters for touchstart, mousedown, pointerdown invocation

Also added a PointerEventDispatch counter specific to pointerdowns,
so be able to guess the # of JS-fired events (the difference between
PointerEventDispatchPointerDown & PointerDownFired).

BUG=
TBR=isherman@chromium.org
==========

to

==========
Added UseCounters for touchstart, mousedown, pointerdown invocation

Also added a PointerEventDispatch counter specific to pointerdowns,
so be able to guess the # of JS-fired events (the difference between
PointerEventDispatchPointerDown & PointerDownFired).

BUG=
TBR=isherman@chromium.org

Committed: https://crrev.com/1f97115c84c175bb4e72d4c4eea6e277b8242b03
Cr-Commit-Position: refs/heads/master@{#406487}
==========

[commit-bot: I haz the power, 2016-07-20 04:33:04]

Patchset 5 (id:??) landed as
https://crrev.com/1f97115c84c175bb4e72d4c4eea6e277b8242b03
Cr-Commit-Position: refs/heads/master@{#406487}