Issue 2160343003: Use the Code's pointer offsets to find object references when disassembling IA32.

Issue 2160343003: Use the Code's pointer offsets to find object references when disassembling IA32. (Closed)

Created:
4 years, 5 months ago by rmacnak

Modified:
4 years, 5 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use the Code's pointer offsets to find object references when disassembling IA32. Attempt to de-flake language/disassemble_test by removing a heap walk. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/883f25ff08ccb035a3bcadb6bc81a1dcbe44a852

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -169 lines)			Patch
M	runtime/vm/disassembler.h	View		4 chunks	+5 lines, -17 lines	0 comments	Download
M	runtime/vm/disassembler.cc	View		6 chunks	+10 lines, -31 lines	0 comments	Download
M	runtime/vm/disassembler_arm.cc	View		3 chunks	+11 lines, -2 lines	0 comments	Download
M	runtime/vm/disassembler_arm64.cc	View		3 chunks	+11 lines, -1 line	0 comments	Download
M	runtime/vm/disassembler_dbc.cc	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View		3 chunks	+21 lines, -60 lines	0 comments	Download
M	runtime/vm/disassembler_mips.cc	View	1	3 chunks	+11 lines, -1 line	0 comments	Download
M	runtime/vm/disassembler_x64.cc	View		4 chunks	+11 lines, -57 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 5 months ago (2016-07-20 00:25:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
883f25ff08ccb035a3bcadb6bc81a1dcbe44a852 (presubmit successful).