Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2160343002: Rename remaining xfa_script_* files. (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@rename_cscript
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename remaining xfa_script_* files. This Cl renames the remaining xfa_script_* files to match the class names contained within the files. Committed: https://pdfium.googlesource.com/pdfium/+/31f8740fe51ceca8e973a2efe40d4d440d7a5cb7

Patch Set 1 #

Total comments: 6

Patch Set 2 : Rebase to master #

Patch Set 3 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -2415 lines) Patch
M BUILD.gn View 3 chunks +7 lines, -7 lines 0 comments Download
M xfa.gyp View 3 chunks +7 lines, -7 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdochandler.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_datawindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_eventpseudomodel.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fxfa/parser/cscript_hostpseudomodel.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cscript_layoutpseudomodel.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fxfa/parser/cscript_logpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_signaturepseudomodel.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_node.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fxfa/parser/cxfa_nodehelper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_nodehelper.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_nodelist.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fxfa/parser/cxfa_resolveprocessor.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_resolveprocessor.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_scriptcontext.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_scriptcontext.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/cxfa_valuearray.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data_element_script.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_imp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_layout_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_appadapter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_locale.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
A + xfa/fxfa/parser/xfa_resolvenode_rs.h View 2 chunks +3 lines, -3 lines 0 comments Download
D xfa/fxfa/parser/xfa_script.h View 1 chunk +0 lines, -68 lines 0 comments Download
D xfa/fxfa/parser/xfa_script_imp.h View 1 chunk +0 lines, -126 lines 0 comments Download
D xfa/fxfa/parser/xfa_script_imp.cpp View 1 chunk +0 lines, -739 lines 0 comments Download
D xfa/fxfa/parser/xfa_script_nodehelper.h View 1 chunk +0 lines, -72 lines 0 comments Download
D xfa/fxfa/parser/xfa_script_nodehelper.cpp View 1 chunk +0 lines, -429 lines 0 comments Download
D xfa/fxfa/parser/xfa_script_resolveprocessor.h View 1 chunk +0 lines, -78 lines 0 comments Download
D xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 1 chunk +0 lines, -826 lines 0 comments Download
M xfa/fxfa/parser/xfa_utils_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
dsinclair
PTAL. I left the copyright dates, I never know when they should be updated or ...
4 years, 5 months ago (2016-07-19 19:17:22 UTC) #3
Wei Li
lgtm https://codereview.chromium.org/2160343002/diff/1/xfa/fxfa/app/xfa_ffdochandler.cpp File xfa/fxfa/app/xfa_ffdochandler.cpp (right): https://codereview.chromium.org/2160343002/diff/1/xfa/fxfa/app/xfa_ffdochandler.cpp#newcode11 xfa/fxfa/app/xfa_ffdochandler.cpp:11: #include "xfa/fxfa/parser/cxfa_scriptcontext.h" xfa_resolvenode_rs.h is also needed https://codereview.chromium.org/2160343002/diff/1/xfa/fxfa/app/xfa_ffwidgetacc.cpp File ...
4 years, 5 months ago (2016-07-19 21:51:54 UTC) #4
dsinclair
https://codereview.chromium.org/2160343002/diff/1/xfa/fxfa/app/xfa_ffdochandler.cpp File xfa/fxfa/app/xfa_ffdochandler.cpp (right): https://codereview.chromium.org/2160343002/diff/1/xfa/fxfa/app/xfa_ffdochandler.cpp#newcode11 xfa/fxfa/app/xfa_ffdochandler.cpp:11: #include "xfa/fxfa/parser/cxfa_scriptcontext.h" On 2016/07/19 21:51:54, Wei Li wrote: > ...
4 years, 5 months ago (2016-07-20 13:20:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160343002/60001
4 years, 5 months ago (2016-07-20 13:20:58 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 13:34:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/31f8740fe51ceca8e973a2efe40d4d440d7a...

Powered by Google App Engine
This is Rietveld 408576698