Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2160303004:
Add missing dependency to components_unittests GYP build (Closed)
DescriptionAdd missing dependency to components_unittests GYP build
It should have been added in http://crrev.com/2064463002
BUG=chromium:615223
TEST=build components_unittests with GYP, components_unittests passes
TBR=hayato@chromium.org, wfh@chromium.org
NOTRY=true
NOTREECHECKS=true
Committed: https://crrev.com/d149b80d547b9766d90159f80e931005acf1b433
Cr-Commit-Position: refs/heads/master@{#406478}
Patch Set 1 #
Messages
Total messages: 26 (14 generated)
Description was changed from ========== Add missing dependency to components_unittests GYP build BUG=chromium:615223 TEST=build components_unittests with GYP, components_unittests passes R=hayato@chromium.org, wfh@chromium.org ========== to ========== Add missing dependency to components_unittests GYP build BUG=chromium:615223 TEST=build components_unittests with GYP, components_unittests passes TBR=hayato@chromium.org, wfh@chromium.org NOTRY=true ==========
Description was changed from ========== Add missing dependency to components_unittests GYP build BUG=chromium:615223 TEST=build components_unittests with GYP, components_unittests passes TBR=hayato@chromium.org, wfh@chromium.org NOTRY=true ========== to ========== Add missing dependency to components_unittests GYP build It should have been added in http://crrev.com/2064463002 BUG=chromium:615223 TEST=build components_unittests with GYP, components_unittests passes TBR=hayato@chromium.org, wfh@chromium.org NOTRY=true ==========
The CQ bit was checked by sque@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
llozano@google.com changed reviewers: + llozano@google.com
The CQ bit was checked by llozano@google.com
lgtm
The CQ bit was checked by sque@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by sque@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add missing dependency to components_unittests GYP build It should have been added in http://crrev.com/2064463002 BUG=chromium:615223 TEST=build components_unittests with GYP, components_unittests passes TBR=hayato@chromium.org, wfh@chromium.org NOTRY=true ========== to ========== Add missing dependency to components_unittests GYP build It should have been added in http://crrev.com/2064463002 BUG=chromium:615223 TEST=build components_unittests with GYP, components_unittests passes TBR=hayato@chromium.org, wfh@chromium.org NOTRY=true NOTREECHECKS=true ==========
The CQ bit was unchecked by sque@chromium.org
The CQ bit was checked by sque@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add missing dependency to components_unittests GYP build It should have been added in http://crrev.com/2064463002 BUG=chromium:615223 TEST=build components_unittests with GYP, components_unittests passes TBR=hayato@chromium.org, wfh@chromium.org NOTRY=true NOTREECHECKS=true ========== to ========== Add missing dependency to components_unittests GYP build It should have been added in http://crrev.com/2064463002 BUG=chromium:615223 TEST=build components_unittests with GYP, components_unittests passes TBR=hayato@chromium.org, wfh@chromium.org NOTRY=true NOTREECHECKS=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add missing dependency to components_unittests GYP build It should have been added in http://crrev.com/2064463002 BUG=chromium:615223 TEST=build components_unittests with GYP, components_unittests passes TBR=hayato@chromium.org, wfh@chromium.org NOTRY=true NOTREECHECKS=true ========== to ========== Add missing dependency to components_unittests GYP build It should have been added in http://crrev.com/2064463002 BUG=chromium:615223 TEST=build components_unittests with GYP, components_unittests passes TBR=hayato@chromium.org, wfh@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/d149b80d547b9766d90159f80e931005acf1b433 Cr-Commit-Position: refs/heads/master@{#406478} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d149b80d547b9766d90159f80e931005acf1b433 Cr-Commit-Position: refs/heads/master@{#406478}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2161013005/ by engedy@chromium.org. The reason for reverting is: This was a follow-up for https://codereview.chromium.org/2064463002/, which has been reverted in the meantime in https://codereview.chromium.org/2166553003/, and now this second CL by its lonesome is causing compile error on "Linux Chromium OS ASan LSan Builder". . |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
