Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: net/android/network_change_notifier_delegate_android.h

Issue 2160263002: Use supported Android network handles in Android M and newer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment parseInt Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/android/network_change_notifier_delegate_android.h
diff --git a/net/android/network_change_notifier_delegate_android.h b/net/android/network_change_notifier_delegate_android.h
index 6e710a0cd0d47795e59068c1d339fda53ffef2e3..8b6d0e86b39fbe2e76a9d693f9425735449ec205 100644
--- a/net/android/network_change_notifier_delegate_android.h
+++ b/net/android/network_change_notifier_delegate_android.h
@@ -54,7 +54,7 @@ class NET_EXPORT_PRIVATE NetworkChangeNotifierDelegateAndroid {
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
jint new_connection_type,
- jint default_netid);
+ jlong default_netid);
jint GetConnectionType(JNIEnv* env, jobject obj) const;
// Called from NetworkChangeNotifier.java on the JNI thread whenever
@@ -77,20 +77,20 @@ class NET_EXPORT_PRIVATE NetworkChangeNotifierDelegateAndroid {
// NetworkChangeNotifierAutoDetect.Observer functions of the same names.
void NotifyOfNetworkConnect(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
- jint net_id,
+ jlong net_id,
jint connection_type);
void NotifyOfNetworkSoonToDisconnect(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
- jint net_id);
+ jlong net_id);
void NotifyOfNetworkDisconnect(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
- jint net_id);
+ jlong net_id);
void NotifyPurgeActiveNetworkList(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
- const base::android::JavaParamRef<jintArray>& active_networks);
+ const base::android::JavaParamRef<jlongArray>& active_networks);
// These methods can be called on any thread. Note that the provided observer
// will be notified on the thread AddObserver() is called on.
@@ -119,11 +119,11 @@ class NET_EXPORT_PRIVATE NetworkChangeNotifierDelegateAndroid {
// Map of active connected networks and their connection type.
typedef std::map<NetworkHandle, ConnectionType> NetworkMap;
- // Converts a Java int[] into a NetworkMap. Expects int[] to contain
+ // Converts a Java long[] into a NetworkMap. Expects long[] to contain
// repeated instances of: NetworkHandle, ConnectionType
- static void JavaIntArrayToNetworkMap(JNIEnv* env,
- jintArray int_array,
- NetworkMap* network_map);
+ static void JavaLongArrayToNetworkMap(JNIEnv* env,
+ jlongArray long_array,
+ NetworkMap* network_map);
// Setters that grab appropriate lock.
void SetCurrentConnectionType(ConnectionType connection_type);

Powered by Google App Engine
This is Rietveld 408576698