[MD History] Move the shared menu from history list to list container.

chrome/browser/resources/md_history/history_list.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'history-list',
 
   properties: {
     // The search term for the current query. Set when the query returns.
     searchedTerm: {
       type: String,
       value: '',
     },
 
     lastSearchedTerm_: String,
 
     querying: Boolean,
 
     // An array of history entries in reverse chronological order.
     historyData_: Array,
 
     resultLoadingDisabled_: {
       type: Boolean,
       value: false,
     },
   },
 
   listeners: {
-    'infinite-list.scroll': 'closeMenu_',
-    'tap': 'closeMenu_',
-    'toggle-menu': 'toggleMenu_',
+    'infinite-list.scroll': 'notifyListScroll_',

[tsergeant, 2016/07/19 07:12:47]

Rather than firing a new event, can you just close the menu on any scroll event
that makes it up to the list container?

[calamity, 2016/07/20 05:24:38]

As discussed, the scroll event doesn't bubble.

     'remove-bookmark-stars': 'removeBookmarkStars_',
   },
 
   /** @override */
   attached: function() {
     // It is possible (eg, when middle clicking the reload button) for all other
     // resize events to fire before the list is attached and can be measured.
     // Adding another resize here ensures it will get sized correctly.
     /** @type {IronListElement} */(this.$['infinite-list']).notifyResize();
   },
 
   /**
-   * Closes the overflow menu.
-   * @private
-   */
-  closeMenu_: function() {
-    /** @type {CrSharedMenuElement} */(this.$.sharedMenu).closeMenu();
-  },
-
-  /**
-   * Opens the overflow menu unless the menu is already open and the same button
-   * is pressed.
-   * @param {{detail: {item: !HistoryEntry, target: !HTMLElement}}} e
-   * @private
-   */
-  toggleMenu_: function(e) {
-    var target = e.detail.target;
-    /** @type {CrSharedMenuElement} */(this.$.sharedMenu).toggleMenu(
-        target, e.detail.item);
-  },
-
-  /**
    * Remove bookmark star for history items with matching URLs.
    * @param {{detail: !string}} e
    * @private
    */
   removeBookmarkStars_: function(e) {
     var url = e.detail;
 
     if (this.historyData_ === undefined)
       return;
 
     for (var i = 0; i < this.historyData_.length; i++) {
       if (this.historyData_[i].url == url)
         this.set('historyData_.' + i + '.starred', false);
     }
   },
 
-  /** @private */
-  onMoreFromSiteTap_: function() {
-    var menu = /** @type {CrSharedMenuElement} */(this.$.sharedMenu);
-    this.fire('search-domain', {domain: menu.itemData.domain});
-    menu.closeMenu();
-  },
-
-  /** @private */
-  onRemoveFromHistoryTap_: function() {
-    var menu = /** @type {CrSharedMenuElement} */(this.$.sharedMenu);
-    md_history.BrowserService.getInstance()
-        .deleteItems([menu.itemData])
-        .then(function(items) {
-          this.removeDeletedHistory_(items);
-          // This unselect-all is to reset the toolbar when deleting a selected
-          // item. TODO(tsergeant): Make this automatic based on observing list
-          // modifications.
-          this.fire('unselect-all');
-        }.bind(this));
-    menu.closeMenu();
-  },
-
   /**
    * Disables history result loading when there are no more history results.
    */
   disableResultLoading: function() {
     this.resultLoadingDisabled_ = true;
   },
 
   /**
    * Adds the newly updated history results into historyData_. Adds new fields
    * for each result.
@@ skipping 161 matching lines @@
         this.historyData_[i + 1].dateRelativeDay;
   },
 
   /**
    * @param {number} index
    * @return {boolean}
    * @private
    */
   isFirstItem_: function(index) {
     return index == 0;
-  }
+  },
+
+  /**
+   * @private
+   */
+  notifyListScroll_: function() {
+    this.fire('history-list-scrolled');
+  },
 });