Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: content/browser/indexed_db/indexed_db_transaction.h

Issue 2160163002: [IndexedDB] Propogating Changes to Observer : Browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Browser changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_transaction.h
diff --git a/content/browser/indexed_db/indexed_db_transaction.h b/content/browser/indexed_db/indexed_db_transaction.h
index ae1863b151f161ab6fc82e3ca1b575171d784568..130f08df1f7d59ab556b785f9c1625c705a760d7 100644
--- a/content/browser/indexed_db/indexed_db_transaction.h
+++ b/content/browser/indexed_db/indexed_db_transaction.h
@@ -18,8 +18,10 @@
#include "base/time/time.h"
#include "base/timer/timer.h"
#include "content/browser/indexed_db/indexed_db_backing_store.h"
+#include "content/browser/indexed_db/indexed_db_connection.h"
#include "content/browser/indexed_db/indexed_db_database.h"
#include "content/browser/indexed_db/indexed_db_database_error.h"
+#include "content/browser/indexed_db/indexed_db_observer.h"
#include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBTypes.h"
namespace content {
@@ -27,6 +29,8 @@ namespace content {
class BlobWriteCallbackImpl;
class IndexedDBCursor;
class IndexedDBDatabaseCallbacks;
+class IndexedDBObservation;
+class IndexedDBObserverChanges;
class CONTENT_EXPORT IndexedDBTransaction
: public NON_EXPORTED_BASE(base::RefCounted<IndexedDBTransaction>) {
@@ -63,13 +67,26 @@ class CONTENT_EXPORT IndexedDBTransaction
pending_preemptive_events_--;
DCHECK_GE(pending_preemptive_events_, 0);
}
+ void AddPendingObserver(int32_t observer_id, IndexedDBObserver::Options);
+ // Delete pending observers with ID's listed in |pending_observer_ids|.
+ void RemovePendingObservers(const std::vector<int32_t>& pending_observer_ids);
+
+ // Adds observation for the connection.
+ void AddObservation(int32_t connection_id,
+ std::unique_ptr<IndexedDBObservation>);
+ // Adds the last observation index to observer_id's list of recorded
+ // observation indices.
+ void RecordObserverForLastObservation(int32_t connection_id,
+ int32_t observer_id);
+
IndexedDBBackingStore::Transaction* BackingStoreTransaction() {
return transaction_.get();
}
int64_t id() const { return id_; }
IndexedDBDatabase* database() const { return database_.get(); }
- IndexedDBDatabaseCallbacks* connection() const { return callbacks_.get(); }
+ IndexedDBDatabaseCallbacks* callbacks() const { return callbacks_.get(); }
+ IndexedDBConnection* connection() const { return connection_.get(); }
State state() const { return state_; }
bool IsTimeoutTimerRunning() const { return timeout_timer_.IsRunning(); }
@@ -88,10 +105,9 @@ class CONTENT_EXPORT IndexedDBTransaction
// IndexedDBClassFactory.
IndexedDBTransaction(
int64_t id,
- scoped_refptr<IndexedDBDatabaseCallbacks> callbacks,
+ base::WeakPtr<IndexedDBConnection> connection,
const std::set<int64_t>& object_store_ids,
blink::WebIDBTransactionMode mode,
- IndexedDBDatabase* db,
IndexedDBBackingStore::Transaction* backing_store_transaction);
virtual ~IndexedDBTransaction();
@@ -111,6 +127,7 @@ class CONTENT_EXPORT IndexedDBTransaction
FRIEND_TEST_ALL_PREFIXES(IndexedDBTransactionTestMode,
ScheduleNormalTask);
FRIEND_TEST_ALL_PREFIXES(IndexedDBTransactionTest, Timeout);
+ FRIEND_TEST_ALL_PREFIXES(IndexedDBTransactionTest, IndexedDBObserver);
void RunTasksIfStarted();
@@ -130,9 +147,15 @@ class CONTENT_EXPORT IndexedDBTransaction
bool used_;
State state_;
bool commit_pending_;
+ base::WeakPtr<IndexedDBConnection> connection_;
scoped_refptr<IndexedDBDatabaseCallbacks> callbacks_;
scoped_refptr<IndexedDBDatabase> database_;
+ // Observers in pending queue do not listen to changes until activated.
+ std::vector<std::unique_ptr<IndexedDBObserver>> pending_observers_;
+ std::map<int32_t, std::unique_ptr<IndexedDBObserverChanges>>
+ connection_changes_map_;
+
class TaskQueue {
public:
TaskQueue();

Powered by Google App Engine
This is Rietveld 408576698