[IndexedDB] Propogating Changes to Observer : Browser

[IndexedDB] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the browser end.

* Each transaction has a connection-changes map.
* Changes contain i. array of observations
                  ii. map of observer_id to array of indices from observations, that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to renderer.

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference: https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md

TBR=palmer

BUG=609934
Committed: https://crrev.com/3fee5f7897422fb482c25780fada51b8869c6a8e
Cr-Commit-Position: refs/heads/master@{#406427}

[palakj1, 2016-07-19 01:21:20]

palakj@google.com changed reviewers:
+ cmumford@chromium.org, dmurph@chromium.org, jsbell@chromium.org,
mek@chromium.org

[palakj1, 2016-07-19 01:21:21]

This patch includes Observer changes corresponding to browser.
Besides, IDBObservation file has been renamed from IDBObserverChangesRecord. 
Please have a look.

[palakj1, 2016-07-19 01:23:01]

Description was changed from

==========
[IndexedDBObserver] Propogating Changes to Observer : Browser

BUG= 609934
==========

to

==========
[IndexedDBObserver] Propogating Changes to Observer : Browser

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.


Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

[palakj1, 2016-07-19 01:26:39]

Description was changed from

==========
[IndexedDBObserver] Propogating Changes to Observer : Browser

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.


Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

to

==========
[IndexedDBObserver] Propogating Changes to Observer : Browser

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.

Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

[dmurph, 2016-07-19 01:27:14]

The CQ bit was checked by dmurph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 01:28:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[palakj1, 2016-07-19 01:28:57]

palakj@google.com changed reviewers:
+ palmer@chromium.org

[palakj1, 2016-07-19 01:28:58]

Please have a look

[dmurph, 2016-07-19 01:29:03]

lgtm

[commit-bot: I haz the power, 2016-07-19 01:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 01:33:34]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[cmumford, 2016-07-19 01:38:33]

Can this CL be rebased to ToT and refreshed?

[haraken, 2016-07-19 01:47:39]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-07-19 01:47:40]

WebKit LGTM

https://codereview.chromium.org/2160163002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/indexeddb/IDBObservation.cpp (right):

https://codereview.chromium.org/2160163002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/indexeddb/IDBObservation.cpp:25: return
ScriptValue::from(scriptState, v8::Undefined(scriptState->isolate()));

Can we just return ScriptValue()?

https://codereview.chromium.org/2160163002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/indexeddb/IDBObservation.cpp:33: return
ScriptValue::from(scriptState, v8::Undefined(scriptState->isolate()));

Can we just return ScriptValue()?

https://codereview.chromium.org/2160163002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/indexeddb/IDBObservation.h (right):

https://codereview.chromium.org/2160163002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/indexeddb/IDBObservation.h:37:
IDBObservation(const WebIDBObservation&);

Add explicit.

[palakj1, 2016-07-19 02:03:53]

Please have a look. Already committed changes eliminated.

[palakj1, 2016-07-19 02:40:46]

Please not that the cl reflects changes only at the browser end and therefore,
fails to compile. 
The next cl for the renderer would be fully functional.

[palakj1, 2016-07-19 02:55:06]

Description was changed from

==========
[IndexedDBObserver] Propogating Changes to Observer : Browser

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.

Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

to

==========
[IndexedDBObserver] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end. Note that, it does not build. The CL
https://codereview.chromium.org/2125213002 including renderer changes is
complete.

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.



Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

[palakj1, 2016-07-19 02:55:20]

Description was changed from

==========
[IndexedDBObserver] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end. Note that, it does not build. The CL
https://codereview.chromium.org/2125213002 including renderer changes is
complete.

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.



Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

to

==========
[IndexedDBObserver] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end. Note that, it does not build. 
The CL https://codereview.chromium.org/2125213002 including renderer changes is
complete.

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.



Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

[palakj1, 2016-07-19 02:57:24]

Description was changed from

==========
[IndexedDBObserver] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end. Note that, it does not build. 
The CL https://codereview.chromium.org/2125213002 including renderer changes is
complete.

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.



Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

to

==========
[IndexedDBObserver] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end. 

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.



Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

[palakj1, 2016-07-19 03:10:19]

The CQ bit was checked by palakj@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 03:10:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[palakj1, 2016-07-19 03:11:55]

Updated patch builds.

[commit-bot: I haz the power, 2016-07-19 04:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 04:23:38]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[cmumford, 2016-07-19 14:31:14]

On 2016/07/19 03:11:55, palakj1 wrote:
> Updated patch builds.

It looks like you unintentionally added a backup copy of a source file:
indexed_db_database_back.cc

[cmumford, 2016-07-19 16:00:16]

Mostly all small nits.

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_dispatcher_host.cc:328: for (auto&
observation : changes->release_observations())
const auto& observation

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_observation.h (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observation.h:16: // This class represents
a single observed operation (put/add/delete/clear) of a
Omit "This class".

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observation.h:35: IndexedDBKeyRange
key_range() const { return key_range_; }
const IndexedDBKeyRange& key_range() { ... }
const IndexedDBValue& value() { ... }

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_observer.cc (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observer.cc:12: unsigned short types)
Use int16/int64/etc, rather than the C type short  [runtime/int] [4]

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_observer.h (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observer.h:24: bool include_transaction;
member variables are at end - API is always emphasized.

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observer.h:25: bool no_records;
Seems odd to have a "negative" baked into the variable. I don't see it used yet,
but will this result in something like this?

  if (!options.no_records()) {
    // Add the records.
  }

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observer.h:40: Options options);
const Options&

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_observer_changes.h (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observer_changes.h:26: // to a
Fix line wrap.

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_transaction.cc (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_transaction.cc:356:
connection_changes_map_.clear();
connection_changes_map_ was moved above and is already clear.

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_transaction.cc:366:
pending_observers_.clear();
Also, no need to clear pending_observers_.

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_transaction.cc:470:
IndexedDBObserver::Options options) {
const IndexedDBObserver::Options& options

https://codereview.chromium.org/2160163002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/indexeddb/IDBObservation.cpp (right):

https://codereview.chromium.org/2160163002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/indexeddb/IDBObservation.cpp:14: #include
"modules/indexeddb/IDBKeyRange.h"
IDBObservation.cpp isn't even being compiled with this CL.

[Marijn Kruisselbrink, 2016-07-19 17:16:28]

lgtm, assuming you'll fix some of cmumford's nits

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_transaction.cc (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_transaction.cc:356:
connection_changes_map_.clear();
On 2016/07/19 at 16:00:16, cmumford wrote:
> connection_changes_map_ was moved above and is already clear.

The c++ standard gives no such guarantees. std::unique_ptr is the only std type
that gives any guarantees about the state it is in after you move from it. I
agree that most sane implementations will end up with a cleared map after moving
from it, but this is explicitly not guaranteed, so shouldn't be relied on.

(also just the fact that std::move is called does not necessarily mean that a
move happened. If for some reason SendObservations is later changed to accept
the map as std::map<>&& you would still need to call it with std::move around
the map, but there would be no guarantee that the implementation of it will
actually move from the argument).

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_transaction.cc:366:
pending_observers_.clear();
On 2016/07/19 at 16:00:16, cmumford wrote:
> Also, no need to clear pending_observers_.

Same here, no guarantees what moving from does to an stl container.

[palakj1, 2016-07-19 18:04:14]

Only renaming changes included in IDBObservation.

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_dispatcher_host.cc:328: for (auto&
observation : changes->release_observations())
On 2016/07/19 at 16:00:16, cmumford wrote:
> const auto& observation

Done

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_observation.h (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observation.h:16: // This class represents
a single observed operation (put/add/delete/clear) of a
On 2016/07/19 at 16:00:16, cmumford wrote:
> Omit "This class".

done

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observation.h:35: IndexedDBKeyRange
key_range() const { return key_range_; }
On 2016/07/19 at 16:00:16, cmumford wrote:
> const IndexedDBKeyRange& key_range() { ... }
> const IndexedDBValue& value() { ... }

done

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_observer.h (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observer.h:24: bool include_transaction;
On 2016/07/19 at 16:00:16, cmumford wrote:
> member variables are at end - API is always emphasized.

done

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observer.h:25: bool no_records;
On 2016/07/19 at 16:00:16, cmumford wrote:
> Seems odd to have a "negative" baked into the variable. I don't see it used
yet, but will this result in something like this?
> 
>   if (!options.no_records()) {
>     // Add the records.
>   }
yes, this is how it would be used.
This is a user specified option for not including any record, simply giving a
notification of a change occurring. We want to default to sending some records
like type, key etc. (since, this is the expected use case) and require the user
to explicitly state if no records are needed. That is why the option is
'negative. 
Refer
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md#optio...

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observer.h:40: Options options);
On 2016/07/19 at 16:00:16, cmumford wrote:
> const Options&

done

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_observer_changes.h (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_observer_changes.h:26: // to a
On 2016/07/19 at 16:00:16, cmumford wrote:
> Fix line wrap.

done

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_transaction.cc (right):

https://codereview.chromium.org/2160163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_transaction.cc:470:
IndexedDBObserver::Options options) {
On 2016/07/19 at 16:00:16, cmumford wrote:
> const IndexedDBObserver::Options& options

done

https://codereview.chromium.org/2160163002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/indexeddb/IDBObservation.cpp (right):

https://codereview.chromium.org/2160163002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/indexeddb/IDBObservation.cpp:14: #include
"modules/indexeddb/IDBKeyRange.h"
On 2016/07/19 at 16:00:16, cmumford wrote:
> IDBObservation.cpp isn't even being compiled with this CL.

Sorry for that.
Putting only the renaming changes here. Rest would be a part of renderer cl

[palakj1, 2016-07-19 18:27:09]

The CQ bit was checked by palakj@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 18:28:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cmumford, 2016-07-19 19:41:06]

Change the summary to start with [IndexedDB] instead of [IndexedDBObserver]
because the name in the [] roughly corresponds to the component name (usually).

lgtm

[commit-bot: I haz the power, 2016-07-19 20:08:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 20:08:34]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[palakj1, 2016-07-19 21:31:03]

Description was changed from

==========
[IndexedDBObserver] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end. 

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.



Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

to

==========
[IndexedDB] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end. 

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.



Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

[dmurph, 2016-07-19 21:32:04]

I just chatted with Josh, since the messages change is the same as the other
patch and Chris already lgtm's it, you can put

TBR=palmer

in the message description and submit it when you have everything working.

[palakj1, 2016-07-19 21:32:38]

Description was changed from

==========
[IndexedDB] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end. 

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.



Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

BUG= 609934
==========

to

==========
[IndexedDB] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end. 

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.



Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

TBR=palmer

BUG= 609934
==========

[palakj1, 2016-07-19 21:40:00]

The CQ bit was checked by palakj@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 21:40:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmurph, 2016-07-19 22:41:53]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2016-07-19 22:41:53]

The CQ bit was unchecked by dmurph@chromium.org

[dmurph, 2016-07-19 22:41:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, mek@chromium.org, dmurph@chromium.org,
cmumford@chromium.org
Link to the patchset: https://codereview.chromium.org/2160163002/#ps120001
(title: "Expected tests updated")

[commit-bot: I haz the power, 2016-07-19 22:42:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 00:21:40]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-20 00:24:07]

Description was changed from

==========
[IndexedDB] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end. 

* Each transaction has a connection-changes map.
* Changes contain i. array of observations 
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.



Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md 

TBR=palmer

BUG= 609934
==========

to

==========
[IndexedDB] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end.

* Each transaction has a connection-changes map.
* Changes contain i. array of observations
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.

Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md

TBR=palmer

BUG= 609934

Committed: https://crrev.com/3fee5f7897422fb482c25780fada51b8869c6a8e
Cr-Commit-Position: refs/heads/master@{#406427}
==========

[commit-bot: I haz the power, 2016-07-20 00:24:09]

Patchset 7 (id:??) landed as
https://crrev.com/3fee5f7897422fb482c25780fada51b8869c6a8e
Cr-Commit-Position: refs/heads/master@{#406427}

[palakj1, 2016-07-21 18:41:38]

Description was changed from

==========
[IndexedDB] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end.

* Each transaction has a connection-changes map.
* Changes contain i. array of observations
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.

Current Implementation and Future Scope:
https://docs.google.com/a/google.com/document/d/1viweV7zje2vK9IC-_G0PYlWgGrBh...

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md

TBR=palmer

BUG= 609934

Committed: https://crrev.com/3fee5f7897422fb482c25780fada51b8869c6a8e
Cr-Commit-Position: refs/heads/master@{#406427}
==========

to

==========
[IndexedDB] Propogating Changes to Observer : Browser

The Cl only includes filtering and sending changes to observer only at the
browser end.

* Each transaction has a connection-changes map.
* Changes contain i. array of observations
                  ii. map of observer_id to array of indices from observations,
that the observer is listening to.
* Changes are filtered during transaction operations
* On transaction commit, for each connection, a single changes map is sent to
renderer.

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md

TBR=palmer

BUG= 609934

Committed: https://crrev.com/3fee5f7897422fb482c25780fada51b8869c6a8e
Cr-Commit-Position: refs/heads/master@{#406427}
==========