git_cache.py - Issue 216013002: Suppress spurious warning about overriding cache dir.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cache.py

Issue 216013002: Suppress spurious warning about overriding cache dir. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: git_cache.py

diff --git a/git_cache.py b/git_cache.py

index 9ef4873874e34557211344623e4b41fadfe7d310..828bcf273ac128b741e927302ed817d9d8488a42 100755

--- a/git_cache.py

+++ b/git_cache.py

@@ -290,7 +290,8 @@ class OptionParser(optparse.OptionParser):

global_cache_dir = subprocess.check_output(

[GIT_EXECUTABLE, 'config', '--global', 'cache.cachepath']).strip()

if options.cache_dir:

- logging.warn('Overriding globally-configured cache directory.')

+ if global_cache_dir and options.cache_dir != global_cache_dir:

Ryan Tseng 2014/03/28 01:42:45 might need to coerce both sides to abspath to do a

szager1 2014/03/28 06:22:08 Done.

+ logging.warn('Overriding globally-configured cache directory.')

else:

options.cache_dir = global_cache_dir

except subprocess.CalledProcessError:

« no previous file with comments | « no previous file | no next file » | no next file with comments »