Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 216013002: Suppress spurious warning about overriding cache dir. (Closed)

Created:
6 years, 9 months ago by szager1
Modified:
6 years, 9 months ago
Reviewers:
Ryan Tseng, iannucci, hinoka
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Suppress spurious warning about overriding cache dir. R=iannucci@chromium.org,hinoka@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=260078

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M git_cache.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
szager1
6 years, 9 months ago (2014-03-28 01:37:40 UTC) #1
Ryan Tseng
lgtm https://codereview.chromium.org/216013002/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/216013002/diff/1/git_cache.py#newcode293 git_cache.py:293: if global_cache_dir and options.cache_dir != global_cache_dir: might need ...
6 years, 9 months ago (2014-03-28 01:42:45 UTC) #2
szager1
https://codereview.chromium.org/216013002/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/216013002/diff/1/git_cache.py#newcode293 git_cache.py:293: if global_cache_dir and options.cache_dir != global_cache_dir: On 2014/03/28 01:42:45, ...
6 years, 9 months ago (2014-03-28 06:22:08 UTC) #3
szager1
The CQ bit was checked by szager@chromium.org
6 years, 9 months ago (2014-03-28 06:22:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/216013002/20001
6 years, 9 months ago (2014-03-28 06:22:20 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 06:24:13 UTC) #6
Message was sent while issue was closed.
Change committed as 260078

Powered by Google App Engine
This is Rietveld 408576698