Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2160123002: Converted Observatory nav-menu-item element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Better Tests #

Total comments: 2

Patch Set 3 : Converted from single to triple quotes #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -51 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 chunk +1 line, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/nav/menu_item.dart View 1 2 1 chunk +114 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/nav/menu_item_wrapper.dart View 1 chunk +54 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.html View 1 chunk +0 lines, -44 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 1 chunk +2 lines, -0 lines 4 comments Download
A runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.dart View 1 1 chunk +70 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-18 22:57:27 UTC) #2
cbernaschina
4 years, 5 months ago (2016-07-18 23:20:10 UTC) #3
Cutch
lgtm https://codereview.chromium.org/2160123002/diff/20001/runtime/observatory/lib/src/elements/nav/menu_item.dart File runtime/observatory/lib/src/elements/nav/menu_item.dart (right): https://codereview.chromium.org/2160123002/diff/20001/runtime/observatory/lib/src/elements/nav/menu_item.dart#newcode13 runtime/observatory/lib/src/elements/nav/menu_item.dart:13: style.text = 'li.nav-menu-item {' use ''' quotes with ...
4 years, 5 months ago (2016-07-19 14:20:44 UTC) #4
cbernaschina
https://codereview.chromium.org/2160123002/diff/20001/runtime/observatory/lib/src/elements/nav/menu_item.dart File runtime/observatory/lib/src/elements/nav/menu_item.dart (right): https://codereview.chromium.org/2160123002/diff/20001/runtime/observatory/lib/src/elements/nav/menu_item.dart#newcode13 runtime/observatory/lib/src/elements/nav/menu_item.dart:13: style.text = 'li.nav-menu-item {' On 2016/07/19 14:20:44, Cutch wrote: ...
4 years, 5 months ago (2016-07-19 19:17:55 UTC) #5
rmacnak
lgtm https://chromiumcodereview.appspot.com/2160123002/diff/40001/runtime/observatory/observatory_sources.gypi File runtime/observatory/observatory_sources.gypi (right): https://chromiumcodereview.appspot.com/2160123002/diff/40001/runtime/observatory/observatory_sources.gypi#newcode121 runtime/observatory/observatory_sources.gypi:121: 'lib/src/elements/nav/menu_item.html', .dart https://chromiumcodereview.appspot.com/2160123002/diff/40001/runtime/observatory/observatory_sources.gypi#newcode122 runtime/observatory/observatory_sources.gypi:122: 'lib/src/elements/nav/menu_item_wrapper.html', .dart
4 years, 5 months ago (2016-07-19 22:31:16 UTC) #6
cbernaschina
Committed patchset #3 (id:40001) manually as 9fb05ba1f843888548fc4e98c8b2582b9174fc7e (presubmit successful).
4 years, 5 months ago (2016-07-19 22:45:19 UTC) #8
cbernaschina
4 years, 5 months ago (2016-07-19 22:46:10 UTC) #9
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/2160123002/diff/40001/runtime/observat...
File runtime/observatory/observatory_sources.gypi (right):

https://chromiumcodereview.appspot.com/2160123002/diff/40001/runtime/observat...
runtime/observatory/observatory_sources.gypi:121:
'lib/src/elements/nav/menu_item.html',
On 2016/07/19 22:31:16, rmacnak wrote:
> .dart

Done.

https://chromiumcodereview.appspot.com/2160123002/diff/40001/runtime/observat...
runtime/observatory/observatory_sources.gypi:122:
'lib/src/elements/nav/menu_item_wrapper.html',
On 2016/07/19 22:31:16, rmacnak wrote:
> .dart

Done.

Powered by Google App Engine
This is Rietveld 408576698