Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2160113003: Revert of Remove Mac10.11 specifiers from TestExpectations as an experiment. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove Mac10.11 specifiers from TestExpectations as an experiment. (patchset #1 id:1 of https://codereview.chromium.org/2106903002/ ) Reason for revert: After this was committed, the webkit_tests on the waterfall went red (example build https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/7222) This means that these lines in TestExpectations are *not* without effect. Original issue's description: > Remove Mac10.11 specifiers from TestExpectations as an experiment. > > Due to bug 624020, it seems possible that the Mac10.11 specifiers in TestExpectations have been ignored by the WebKit Mac 10.11 builder; if this is the case, then those specifiers in TestExpectations should have no effect and could theoretically be removed. > > Submitting this CL might cause WebKit Mac 10.11 to fail, and if that happens, then this should be reverted. > > BUG=624020 > > Committed: https://crrev.com/63408fdbcfeaf1bd6fb298afee23ac9563bf218a > Cr-Commit-Position: refs/heads/master@{#406134} TBR=wkorman@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624020 Committed: https://crrev.com/6f6e8febf7b1b5fbcf0b25fc20e29f8d3baa1529 Cr-Commit-Position: refs/heads/master@{#406160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qyearsley
Created Revert of Remove Mac10.11 specifiers from TestExpectations as an experiment.
4 years, 5 months ago (2016-07-19 00:33:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160113003/1
4 years, 5 months ago (2016-07-19 00:34:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 00:36:14 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6f6e8febf7b1b5fbcf0b25fc20e29f8d3baa1529 Cr-Commit-Position: refs/heads/master@{#406160}
4 years, 5 months ago (2016-07-19 00:39:28 UTC) #6
Dirk Pranke
4 years, 5 months ago (2016-07-19 00:42:26 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698