Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 21601002: fix skpdiff viewer bug when using relative paths (Closed)

Created:
7 years, 4 months ago by Zach Reizner
Modified:
7 years, 4 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

fix skpdiff viewer bug when using relative paths BUG=skia:1463 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10515

Patch Set 1 #

Patch Set 2 : mac PATH_MAX #

Total comments: 1

Patch Set 3 : SkString #

Total comments: 1

Patch Set 4 : SkString mega efficiency patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M tools/skpdiff/SkDiffContext.cpp View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M tools/skpdiff/skpdiff_util.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M tools/skpdiff/skpdiff_util.cpp View 1 2 3 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Zach Reizner
7 years, 4 months ago (2013-08-01 18:13:06 UTC) #1
djsollen
https://codereview.chromium.org/21601002/diff/5001/tools/skpdiff/skpdiff_util.h File tools/skpdiff/skpdiff_util.h (right): https://codereview.chromium.org/21601002/diff/5001/tools/skpdiff/skpdiff_util.h#newcode58 tools/skpdiff/skpdiff_util.h:58: char* get_absolute_path(const char path[]); SkString ...(const SkString& path); That ...
7 years, 4 months ago (2013-08-01 18:44:00 UTC) #2
Zach Reizner
7 years, 4 months ago (2013-08-01 19:46:24 UTC) #3
djsollen
https://codereview.chromium.org/21601002/diff/11001/tools/skpdiff/skpdiff_util.cpp File tools/skpdiff/skpdiff_util.cpp (right): https://codereview.chromium.org/21601002/diff/11001/tools/skpdiff/skpdiff_util.cpp#newcode192 tools/skpdiff/skpdiff_util.cpp:192: char fullPath[PATH_MAX + 1]; SkString fullPath(PATH_MAX + 1); if ...
7 years, 4 months ago (2013-08-01 20:03:32 UTC) #4
Zach Reizner
7 years, 4 months ago (2013-08-01 20:21:00 UTC) #5
djsollen
lgtm
7 years, 4 months ago (2013-08-01 20:21:34 UTC) #6
Zach Reizner
7 years, 4 months ago (2013-08-02 15:54:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r10515 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698