Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 216003002: Avoid exposing disabled CSS properties in will-change and transition (Closed)

Created:
6 years, 8 months ago by dstockwell
Modified:
6 years, 8 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Avoid exposing disabled CSS properties in will-change and transition Both transition and will-change should produce string values for unknown properties, but were producing identifiers. transition requires follow on work as it only currently considers valid property names. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170286

Patch Set 1 #

Patch Set 2 : Move checking to transition and will-change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/core/css/parser/CSSPropertyParser.cpp View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
dstockwell
6 years, 8 months ago (2014-03-28 01:31:19 UTC) #1
esprehn
lgtm, No test? :(
6 years, 8 months ago (2014-03-28 02:36:09 UTC) #2
dstockwell
On 2014/03/28 02:36:09, esprehn wrote: > lgtm, No test? :( Not sure there's a good ...
6 years, 8 months ago (2014-03-28 03:22:21 UTC) #3
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 8 months ago (2014-03-28 03:35:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/216003002/20001
6 years, 8 months ago (2014-03-28 03:35:15 UTC) #5
dstockwell
The CQ bit was unchecked by dstockwell@chromium.org
6 years, 8 months ago (2014-03-28 06:22:50 UTC) #6
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 8 months ago (2014-03-28 06:23:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/216003002/20001
6 years, 8 months ago (2014-03-28 06:23:09 UTC) #8
dstockwell
The CQ bit was unchecked by dstockwell@chromium.org
6 years, 8 months ago (2014-03-28 06:33:02 UTC) #9
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 8 months ago (2014-03-28 06:33:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/216003002/20001
6 years, 8 months ago (2014-03-28 06:33:15 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 06:33:44 UTC) #12
Message was sent while issue was closed.
Change committed as 170286

Powered by Google App Engine
This is Rietveld 408576698