Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Issue 2160013003: Revert of Add a PGO tag for the PGO builds in chrome://version (Closed)

Created:
4 years, 5 months ago by Sébastien Marchand
Modified:
4 years, 5 months ago
Reviewers:
sky, brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a PGO tag for the PGO builds in chrome://version (patchset #3 id:40001 of https://codereview.chromium.org/2157563002/ ) Reason for revert: It's breaking a chromiumos bot: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/23038 Original issue's description: > Add a PGO tag for the PGO builds in chrome://version > > Also remove the VS2013 version string as we don't support it anymore. > > BUG=309849 > > Committed: https://crrev.com/cbb31e640ae7ee7a9e03df917d5bba25415c13f0 > Cr-Commit-Position: refs/heads/master@{#406119} TBR=brucedawson@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=309849 Committed: https://crrev.com/e49ea0da33c0e6300ed45386a2b9acbd59b354e8 Cr-Commit-Position: refs/heads/master@{#406127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/chrome_features.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_features.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/features.gni View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sébastien Marchand
Created Revert of Add a PGO tag for the PGO builds in chrome://version
4 years, 5 months ago (2016-07-18 22:55:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160013003/1
4 years, 5 months ago (2016-07-18 22:55:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 22:56:18 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 22:57:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e49ea0da33c0e6300ed45386a2b9acbd59b354e8
Cr-Commit-Position: refs/heads/master@{#406127}

Powered by Google App Engine
This is Rietveld 408576698