Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeDisableIf.java

Issue 2160013002: Add device format filter in DisableIf() annotation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change mTargetContext to ChromeInstrumentationTestRunner.java. Change type name to be simpler. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeDisableIf.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeDisableIf.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeDisableIf.java
new file mode 100644
index 0000000000000000000000000000000000000000..24bb7c9915ae3e2b57244e7d7bdfc8a964e0d813
--- /dev/null
+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeDisableIf.java
@@ -0,0 +1,19 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.test.util;
+
+/**
+ * Disable if enums that are usable with the @DisableIf but in the chrome/ layer.
+ *
+ * e.g. @DisableIf.Device({ChromeDisableIf.PHONE})
+ */
+public final class ChromeDisableIf {
+ /** Specifies the test is disabled if on phone form factors. */
+ public static final String PHONE = "Phone";
+ /** Specifies the test is disabled if on tablet form factors. */
+ public static final String TABLET = "Tablet";
+ /** Specifies the test is disabled if on large tablet form factors. */
+ public static final String LARGETABLET = "LargeTablet";
Yaron 2016/07/22 15:43:05 LARGE_TABLET
shenghuazhang 2016/07/22 20:37:32 Done.
+}

Powered by Google App Engine
This is Rietveld 408576698