src/core/SkMipMap.cpp - Issue 2159993003: Improve naive SkColorXform to half floats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkMipMap.cpp

Issue 2159993003: Improve naive SkColorXform to half floats (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Prettier code Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkMipMap.cpp

diff --git a/src/core/SkMipMap.cpp b/src/core/SkMipMap.cpp

index 4811c9e07394f9f6cb478da50014ca49d36b53c5..cb9cc85a9874834390ec419b0023298a2302583b 100644

--- a/src/core/SkMipMap.cpp

+++ b/src/core/SkMipMap.cpp

@@ -88,7 +88,9 @@ struct ColorTypeFilter_F16 {

return SkHalfToFloat_finite(x);

}

static uint64_t Compact(const Sk4f& x) {

- return SkFloatToHalf_finite(x);

+ uint64_t r;

+ SkFloatToHalf_finite(x).store(&r);

+ return r;

}

};

« no previous file with comments | « src/core/SkHalf.h ('k') | src/core/SkNx.h » ('j') | no next file with comments »