Split xfa_object_imp into individual class files.

Split xfa_object_imp into individual class files.

This CL splits the CXFA_Object, CXFA_NodeList, CXFA_ThisProxy,
CXFA_ArrayNodeList and CXFA_AttachNodeList out of xfa_object_imp. xfa_object_imp
is then renamed to CXFA_Node.

Committed: https://pdfium.googlesource.com/pdfium/+/5b36f0a0eff7f3666a0e642640db3c89e4bb6748

[dsinclair, 2016-07-18 20:38:04]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-07-18 20:38:05]

PTAL.

This CL splits the file, I'll do a separate pass to reformat things, probably in
multiple CLs.

[Lei Zhang, 2016-07-19 17:20:03]

lgtm

https://codereview.chromium.org/2159973003/diff/40001/xfa.gyp
File xfa.gyp (right):

https://codereview.chromium.org/2159973003/diff/40001/xfa.gyp#newcode442
xfa.gyp:442: "xfa/fxfa/parser/cxfa_attachnodelist.cpp",
alphabetical order

https://codereview.chromium.org/2159973003/diff/40001/xfa/fxfa/parser/cxfa_no...
File xfa/fxfa/parser/cxfa_node.cpp (left):

https://codereview.chromium.org/2159973003/diff/40001/xfa/fxfa/parser/cxfa_no...
xfa/fxfa/parser/cxfa_node.cpp:9: #include <memory>
But we use unique_ptrs all over?

https://codereview.chromium.org/2159973003/diff/40001/xfa/fxfa/parser/cxfa_no...
File xfa/fxfa/parser/cxfa_node.cpp (right):

https://codereview.chromium.org/2159973003/diff/40001/xfa/fxfa/parser/cxfa_no...
xfa/fxfa/parser/cxfa_node.cpp:49: static int32_t
XFA_ScriptInstanceManager_GetCount(CXFA_Node* pInstMgrNode) {
no static inside anonymous namespace, ditto below.

https://codereview.chromium.org/2159973003/diff/40001/xfa/fxfa/parser/cxfa_no...
xfa/fxfa/parser/cxfa_node.cpp:439: void* XFA_GetMapKey_Custom(const
CFX_WideStringC& wsKey) {
Can these go in the anonymous namespace?

[dsinclair, 2016-07-19 17:35:10]

https://codereview.chromium.org/2159973003/diff/40001/xfa.gyp
File xfa.gyp (right):

https://codereview.chromium.org/2159973003/diff/40001/xfa.gyp#newcode442
xfa.gyp:442: "xfa/fxfa/parser/cxfa_attachnodelist.cpp",
On 2016/07/19 17:20:03, Lei Zhang wrote:
> alphabetical order

Done.

https://codereview.chromium.org/2159973003/diff/40001/xfa/fxfa/parser/cxfa_no...
File xfa/fxfa/parser/cxfa_node.cpp (left):

https://codereview.chromium.org/2159973003/diff/40001/xfa/fxfa/parser/cxfa_no...
xfa/fxfa/parser/cxfa_node.cpp:9: #include <memory>
On 2016/07/19 17:20:03, Lei Zhang wrote:
> But we use unique_ptrs all over?

Done.

https://codereview.chromium.org/2159973003/diff/40001/xfa/fxfa/parser/cxfa_no...
File xfa/fxfa/parser/cxfa_node.cpp (right):

https://codereview.chromium.org/2159973003/diff/40001/xfa/fxfa/parser/cxfa_no...
xfa/fxfa/parser/cxfa_node.cpp:49: static int32_t
XFA_ScriptInstanceManager_GetCount(CXFA_Node* pInstMgrNode) {
On 2016/07/19 17:20:03, Lei Zhang wrote:
> no static inside anonymous namespace, ditto below.

Doh, missed those two, thanks.

https://codereview.chromium.org/2159973003/diff/40001/xfa/fxfa/parser/cxfa_no...
xfa/fxfa/parser/cxfa_node.cpp:439: void* XFA_GetMapKey_Custom(const
CFX_WideStringC& wsKey) {
On 2016/07/19 17:20:03, Lei Zhang wrote:
> Can these go in the anonymous namespace?

Thought there was a reason I left these out, but I don't see it. Moved to
anonymous.

[dsinclair, 2016-07-19 17:35:23]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-19 17:35:23]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2159973003/#ps60001
(title: "Review fixes")

[commit-bot: I haz the power, 2016-07-19 17:35:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 17:37:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 17:37:38]

Try jobs failed on following builders:
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[dsinclair, 2016-07-19 17:45:04]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-19 17:45:04]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2159973003/#ps80001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-07-19 17:45:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 17:56:26]

Description was changed from

==========
Split xfa_object_imp into individual class files.

This CL splits the CXFA_Object, CXFA_NodeList, CXFA_ThisProxy,
CXFA_ArrayNodeList and CXFA_AttachNodeList out of xfa_object_imp. xfa_object_imp
is then renamed to CXFA_Node.
==========

to

==========
Split xfa_object_imp into individual class files.

This CL splits the CXFA_Object, CXFA_NodeList, CXFA_ThisProxy,
CXFA_ArrayNodeList and CXFA_AttachNodeList out of xfa_object_imp. xfa_object_imp
is then renamed to CXFA_Node.

Committed:
https://pdfium.googlesource.com/pdfium/+/5b36f0a0eff7f3666a0e642640db3c89e4bb...
==========

[commit-bot: I haz the power, 2016-07-19 17:56:27]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/5b36f0a0eff7f3666a0e642640db3c89e4bb...