Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2159963002: Reland: Make stack tool works for Monochrome (Closed)

Created:
4 years, 5 months ago by michaelbai
Modified:
4 years, 5 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, Torne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Make stack tool works for Monochrome This reverts commit 4369b67a522f5e76e98fbab121b1520274c465e0. Original issue's description: > Make stack tool works for Monochrome > > This patch uses APK offset in debugger output to detect the shared > libraries loaded from APK in output directory. > > It also overwrite the library search path, if the shared libraries > are found in the directory other than default one, e.g. the > secondary abi library in Monochrme. > > This should work well if output directory is set correctly. > > Also add command flag --fallback-monochrome to fallback to > monochrome instead of chrome if the shared library can not be > detected correctly. > > Auto detect ARCH if it is not set in command line. > > BUG=609348 > > Committed: https://crrev.com/ba8d9cfb3ce77706e214a00799e59c0051511a9c > Cr-Commit-Position: refs/heads/master@{#405809} BUG=609348 Committed: https://crrev.com/42d45910ba081c4c699163576aab37f944ef6f46 Cr-Commit-Position: refs/heads/master@{#406215}

Patch Set 1 #

Patch Set 2 : Fix the broken builder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -13 lines) Patch
M third_party/android_platform/development/scripts/stack View 6 chunks +13 lines, -1 line 0 comments Download
M third_party/android_platform/development/scripts/stack_core.py View 1 8 chunks +171 lines, -10 lines 0 comments Download
M third_party/android_platform/development/scripts/symbol.py View 4 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
michaelbai
See the diff between patch set #1 and #2 for changes
4 years, 5 months ago (2016-07-18 19:05:09 UTC) #3
sgurun-gerrit only
On 2016/07/18 19:05:09, michaelbai wrote: > See the diff between patch set #1 and #2 ...
4 years, 5 months ago (2016-07-18 22:41:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159963002/20001
4 years, 5 months ago (2016-07-19 01:14:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/257902)
4 years, 5 months ago (2016-07-19 03:38:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159963002/20001
4 years, 5 months ago (2016-07-19 04:06:54 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 04:42:58 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 04:43:03 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 04:44:25 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42d45910ba081c4c699163576aab37f944ef6f46
Cr-Commit-Position: refs/heads/master@{#406215}

Powered by Google App Engine
This is Rietveld 408576698