Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2159933002: Revert of Disable some GLAndSoftwareCompositing content browser tests under MSAN. (Closed)

Created:
4 years, 5 months ago by ccameron
Modified:
4 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, chrome-apps-syd-reviews_chromium.org, ccameron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable some GLAndSoftwareCompositing content browser tests under MSAN. (patchset #2 id:20001 of https://codereview.chromium.org/1405873002/ ) Reason for revert: This has been fixed. Original issue's description: > Disable some GLAndSoftwareCompositing content browser tests under MSAN. > > These tests give errors when run under MSAN. There is likely a real > problem introduced recently (see bug for details). > > TBR=avi@chromium.org > BUG=542896 > > Committed: https://crrev.com/47cd72d660d736695b0a2f2a2dedc8d189a6bbfe > Cr-Commit-Position: refs/heads/master@{#354224} TBR=avi@chromium.org,benwells@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=542896 Committed: https://crrev.com/c295a3d31ad910952c65258184217e9f04662de4 Cr-Commit-Position: refs/heads/master@{#406080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -63 lines) Patch
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 8 chunks +8 lines, -63 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ccameron
Created Revert of Disable some GLAndSoftwareCompositing content browser tests under MSAN.
4 years, 5 months ago (2016-07-18 18:39:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159933002/1
4 years, 5 months ago (2016-07-18 18:40:30 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/257506)
4 years, 5 months ago (2016-07-18 19:49:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159933002/1
4 years, 5 months ago (2016-07-18 19:51:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 20:13:44 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 20:13:53 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 20:15:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c295a3d31ad910952c65258184217e9f04662de4
Cr-Commit-Position: refs/heads/master@{#406080}

Powered by Google App Engine
This is Rietveld 408576698