Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2159923003: Fix use-after-free in isolate reload. (Closed)

Created:
4 years, 5 months ago by Florian Schneider
Modified:
4 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix use-after-free in isolate reload. The reload context may still be used if an error is reported. BUG=#26895 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/16e577741d1772cba404d2780216438640ff490d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 5 months ago (2016-07-19 00:43:44 UTC) #2
Cutch
LGTM Nice!
4 years, 5 months ago (2016-07-19 13:45:00 UTC) #4
Florian Schneider
4 years, 5 months ago (2016-07-19 17:25:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
16e577741d1772cba404d2780216438640ff490d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698