Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2159913002: Fix apps page icon in tabstrip. (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix apps page icon in tabstrip. Note that the apps button on the bookmark bar works correctly, but if you also bookmark the apps page, the bookmark will be theme-colorized although it probably shouldn't. However, I consider this much more of a corner case than the described bug (which occurs any time you're using the app launcher with a themed browser). So for now, just fix the tabstrip problem. BUG=628599 Review-Url: https://codereview.chromium.org/2150423002 Cr-Commit-Position: refs/heads/master@{#405827} (cherry picked from commit 9130993eeff4cc3b23cff8962c78833e8c81456e) Committed: https://chromium.googlesource.com/chromium/src/+/8efc7a6a5cbca3cdabb1fd374d708b7c60e86ed7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/tabs/tab.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
4 years, 5 months ago (2016-07-18 18:19:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8efc7a6a5cbca3cdabb1fd374d708b7c60e86ed7.

Powered by Google App Engine
This is Rietveld 408576698