ResizeObserver pt1: IDLs with stubs

ResizeObserver pt1: IDLs with stubs

Full ResizeObserver implementation has been split into 7 parts for
cleaner review.

Part 1 is just ResizeObserver IDLs + stubs

Original patch archived at https://codereview.chromium.org/2005593002

BUG=612962
Committed: https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4
Cr-Commit-Position: refs/heads/master@{#406333}

[atotic1, 2016-07-18 23:21:10]

Description was changed from

==========
ResizeObserver pt1: IDLs with stubs

Full ResizeObserver implementation has been split into 7 parts for
cleaner review.

Part 1 is just ResizeObserver IDLs + stubs

Original patch archived at https://codereview.chromium.org/2005593002

BUG=612962
==========

to

==========
ResizeObserver pt1: IDLs with stubs

Full ResizeObserver implementation has been split into 7 parts for
cleaner review.

Part 1 is just ResizeObserver IDLs + stubs

Original patch archived at https://codereview.chromium.org/2005593002

BUG=612962
==========

[atotic1, 2016-07-18 23:21:10]

atotic@google.com changed reviewers:
+ eae@chromium.org, esprehn@chromium.org

[atotic1, 2016-07-18 23:23:52]

ResizeObserver checkin has been chopped up into bits that are easier
to digest. Can you please review part 1?

Upcoming attractions:
1) IDLs with stubs
2) ElementData hookup, ResizeObserverController stubs
3) Fill in IDL stubs, ResizeObserverEntry C++ unit tests
4) ResizeObserverController gathering of observations.
5) ResizeObserverController delivering observations
6) Hook up ResizeObserverController to FrameView polling style + e2e tests
7) Replace FrameView polling with push

[eae, 2016-07-18 23:25:33]

LGTM

[atotic1, 2016-07-18 23:27:04]

The CQ bit was checked by atotic@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 23:28:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-07-19 00:17:58]

lgtm w/ fixes

https://codereview.chromium.org/2159883003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/observer/ResizeObserverEntry.h (right):

https://codereview.chromium.org/2159883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/observer/ResizeObserverEntry.h:22:
ResizeObserverEntry(Element* target);
explicit

https://codereview.chromium.org/2159883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/observer/ResizeObserverEntry.h:26: ClientRect*
contentRect() const { return m_contentRect; }
.get() ? You either want it in both this and target() or neither I think?

[commit-bot: I haz the power, 2016-07-19 03:25:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 03:25:57]

Dry run: This issue passed the CQ dry run.

[atotic1, 2016-07-19 04:28:43]

https://codereview.chromium.org/2159883003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/observer/ResizeObserverEntry.h (right):

https://codereview.chromium.org/2159883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/observer/ResizeObserverEntry.h:26: ClientRect*
contentRect() const { return m_contentRect; }
On 2016/07/19 00:17:58, esprehn wrote:
> .get() ? You either want it in both this and target() or neither I think?

Not sure what you mean here by .get()?

[esprehn, 2016-07-19 05:19:46]

https://codereview.chromium.org/2159883003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/observer/ResizeObserverEntry.h (right):

https://codereview.chromium.org/2159883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/observer/ResizeObserverEntry.h:26: ClientRect*
contentRect() const { return m_contentRect; }
On 2016/07/19 at 04:28:43, atotic1 wrote:
> On 2016/07/19 00:17:58, esprehn wrote:
> > .get() ? You either want it in both this and target() or neither I think?
> 
> Not sure what you mean here by .get()?

Both fields are Member<X>, in target() you do m_target.get() but here you don't.
Do it in both or neither.

[atotic1, 2016-07-19 15:42:23]

The CQ bit was checked by atotic@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 15:42:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 18:37:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 18:37:21]

Dry run: This issue passed the CQ dry run.

[atotic1, 2016-07-19 18:39:28]

The CQ bit was checked by atotic@google.com

[atotic1, 2016-07-19 18:39:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2159883003/#ps20001
(title: "CR fixes")

[commit-bot: I haz the power, 2016-07-19 18:39:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 18:46:28]

Description was changed from

==========
ResizeObserver pt1: IDLs with stubs

Full ResizeObserver implementation has been split into 7 parts for
cleaner review.

Part 1 is just ResizeObserver IDLs + stubs

Original patch archived at https://codereview.chromium.org/2005593002

BUG=612962
==========

to

==========
ResizeObserver pt1: IDLs with stubs

Full ResizeObserver implementation has been split into 7 parts for
cleaner review.

Part 1 is just ResizeObserver IDLs + stubs

Original patch archived at https://codereview.chromium.org/2005593002

BUG=612962
==========

[commit-bot: I haz the power, 2016-07-19 18:46:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-19 18:46:47]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 18:48:38]

Description was changed from

==========
ResizeObserver pt1: IDLs with stubs

Full ResizeObserver implementation has been split into 7 parts for
cleaner review.

Part 1 is just ResizeObserver IDLs + stubs

Original patch archived at https://codereview.chromium.org/2005593002

BUG=612962
==========

to

==========
ResizeObserver pt1: IDLs with stubs

Full ResizeObserver implementation has been split into 7 parts for
cleaner review.

Part 1 is just ResizeObserver IDLs + stubs

Original patch archived at https://codereview.chromium.org/2005593002

BUG=612962

Committed: https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4
Cr-Commit-Position: refs/heads/master@{#406333}
==========

[commit-bot: I haz the power, 2016-07-19 18:48:39]

Patchset 2 (id:??) landed as
https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4
Cr-Commit-Position: refs/heads/master@{#406333}