Issue 2159863002: DevTools: fix closure compilation by adding missing override to ResourceTreeModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2159863002: DevTools: fix closure compilation by adding missing override to ResourceTreeModel (Closed)

Created:
4 years, 5 months ago by lushnikov

Modified:
4 years, 5 months ago

Reviewers:
dgozman

CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: fix closure compilation by adding missing override to ResourceTreeModel This patch adds missing override to WI.ResourceTreeModel. The override was missing in the crrev.com/2132673002 BUG=none TBR=dgozman

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159863002/1

4 years, 5 months ago (2016-07-18 17:36:18 UTC) #3

lushnikov

4 years, 5 months ago (2016-07-18 18:43:20 UTC) #5

Message was sent while issue was closed.

closing in favor of https://codereview.chromium.org/2160613003/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages