Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2159853003: Add bounds info (Closed)

Created:
4 years, 5 months ago by fmenozzi
Modified:
4 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Actually print bounds #

Patch Set 3 : Remove unnecessary verbs table #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M tools/lua/gradients.lua View 1 2 4 chunks +21 lines, -8 lines 0 comments Download
M tools/lua/gradients.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
fmenozzi
ptal
4 years, 5 months ago (2016-07-18 17:47:26 UTC) #3
fmenozzi
Forgot to mention, this will only return correct bounds for draws whose t includes either ...
4 years, 5 months ago (2016-07-18 17:57:24 UTC) #4
fmenozzi
Forgot to actually print the bounds
4 years, 5 months ago (2016-07-18 19:28:38 UTC) #5
reed1
lgtm
4 years, 5 months ago (2016-07-18 19:30:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159853003/40001
4 years, 5 months ago (2016-07-18 20:15:21 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 20:33:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d876a4b549998addbef76c1985f605b8213d86b2

Powered by Google App Engine
This is Rietveld 408576698