Clean up Media_* actions by marking them obsolete and not_user_trigerred.

tools/metrics/actions/actions.xml

Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 66833848b583d96d40d4fe639131be39ade567d0..91729b294763e171be0eee136332b6de162e66f4 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -8557,56 +8557,56 @@ should be able to be added at any place in this file.
   </description>
 </action>
 
-<action name="Media_Paused">
+<action name="Media_Paused" not_user_triggered="true">
   <owner>liberato@chromium.org</owner>
   <description>Media playback was paused.</description>
 </action>
 
-<action name="Media_Play_WithGesture">
+<action name="Media_Play_WithGesture" not_user_triggered="true">
   <owner>liberato@chromium.org</owner>
   <description>A call to play() with a user gesture succeeded.</description>

[Ilya Sherman, 2016/07/18 23:00:12]

Hmm, this seems like it is a user-triggered gesture -- it requires a user
gesture.  Are these metrics perhaps simply obsolete, and replaced by other
metrics?  If so, please remove the code that logs the obsolete metrics.  If not,
could you please clarify what I might be misunderstanding?

[mlamouri (slow - plz ping), 2016/07/19 10:23:50]

You are right, this is coming from a gesture. It was an oversight because in the
cases I'm focusing on, the request comes from the controls. Unfortunately, that
means we will get Play from the controls they Play_WithGesture from the Element
:(

I've also fixed two other oversights: RequestRemotePlayback and
RequestRemotePlayback_Control can only be called from a path requiring a user
gesture.

Note that in all cases, even though these actions must come from a user gesture,
they are arguably not user triggered because they are trigerred from script and
the user might try to do something entirely unrelated.

[Ilya Sherman, 2016/07/20 02:22:19]

Sorry, I'm still not quite clear: Are all of these actions that you're marking
logged only when the action is triggered from a script?  Or, are they logged
both when the user interacts with the controls, and also when JavaScript invokes
these actions?  It would be great if you could update the descriptions for these
metrics to clarify, and indicate what metric to compare them against (if there
is one).

Also: Are these not_user_triggered actions still valuable in some context, or
would it be worthwhile to simply stop logging them?  If they are getting in the
way of your analysis because they are essentially duplicates of other metrics,
it definitely raises the question of what value we're getting from having two
parallel sets of user action metrics for media playback.

 </action>
 
-<action name="Media_Playback_Ended">
+<action name="Media_Playback_Ended" not_user_triggered="true">
   <owner>liberato@chromium.org</owner>
   <description>Media playback reached the end.</description>
 </action>
 
-<action name="Media_Playback_Mute_Off">
+<action name="Media_Playback_Mute_Off" not_user_triggered="true">
   <owner>liberato@chromium.org</owner>
   <description>Mute was turned off.</description>
 </action>
 
-<action name="Media_Playback_Mute_On">
+<action name="Media_Playback_Mute_On" not_user_triggered="true">
   <owner>liberato@chromium.org</owner>
   <description>Mute was turned on.</description>
 </action>
 
-<action name="Media_Playback_Started">
+<action name="Media_Playback_Started" not_user_triggered="true">
   <owner>liberato@chromium.org</owner>
   <description>Media playback started due to any cause.</description>
 </action>
 
-<action name="Media_RequestRemotePlayback">
+<action name="Media_RequestRemotePlayback" not_user_triggered="true">
   <owner>liberato@chromium.org</owner>
   <description>
     User requested to transfer playback to a remote player, via 'cast' button.
   </description>
 </action>
 
-<action name="Media_RequestRemotePlayback_Control">
+<action name="Media_RequestRemotePlayback_Control" not_user_triggered="true">
   <owner>liberato@chromium.org</owner>
   <description>
     User requested to control playback of a remote player, such as Chromecast.
   </description>
 </action>
 
-<action name="Media_Seeked">
+<action name="Media_Seeked" not_user_triggered="true">
   <owner>liberato@chromium.org</owner>
   <description>Seek to different time completed.</description>
 </action>
 
-<action name="Media_SetVolume">
+<action name="Media_SetVolume" not_user_triggered="true">
   <owner>liberato@chromium.org</owner>
   <description>Playback volume was changed.</description>
 </action>