Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: src/profiler/profile-generator.h

Issue 2159793002: [turbofan] Allow deopt reasons without source positions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix for Ignition. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/globals.h ('k') | src/profiler/profile-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profiler/profile-generator.h
diff --git a/src/profiler/profile-generator.h b/src/profiler/profile-generator.h
index 2af1f6583a97f9a03a74bfab27064768211dd9b6..b785eaaf5ff0aeeba6ebf403fe8812be85f45c27 100644
--- a/src/profiler/profile-generator.h
+++ b/src/profiler/profile-generator.h
@@ -73,18 +73,17 @@ class CodeEntry {
void set_deopt_info(const char* deopt_reason, SourcePosition position,
int deopt_id) {
- DCHECK(deopt_position_.IsUnknown());
+ DCHECK(!has_deopt_info());
deopt_reason_ = deopt_reason;
deopt_position_ = position;
deopt_id_ = deopt_id;
}
CpuProfileDeoptInfo GetDeoptInfo();
- const char* deopt_reason() const { return deopt_reason_; }
- SourcePosition deopt_position() const { return deopt_position_; }
- bool has_deopt_info() const { return !deopt_position_.IsUnknown(); }
+ bool has_deopt_info() const { return deopt_id_ != kNoDeoptimizationId; }
void clear_deopt_info() {
deopt_reason_ = kNoDeoptReason;
deopt_position_ = SourcePosition::Unknown();
+ deopt_id_ = kNoDeoptimizationId;
}
void FillFunctionInfo(SharedFunctionInfo* shared);
« no previous file with comments | « src/globals.h ('k') | src/profiler/profile-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698