Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 2159793002: [turbofan] Allow deopt reasons without source positions. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Allow deopt reasons without source positions. This allows to pass deoptimization reasons to the profiler without the requirement of always providing a source position. The absence of deopt reasons is now communicated via a sentinel as the deopt id value. The deoptimization reasons recently added to TurboFan are now passed to the profiler. R=bmeurer@chromium.org TEST=cctest/test-cpu-profiler Committed: https://crrev.com/ca727047837b888b63732d39014d80cae85f7505 Cr-Commit-Position: refs/heads/master@{#37852}

Patch Set 1 #

Patch Set 2 : Fix for Ignition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/profiler/profile-generator.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/profiler/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/profile-generator-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-18 15:11:02 UTC) #4
Benedikt Meurer
Awesome, thanks. LGTM.
4 years, 5 months ago (2016-07-19 04:08:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159793002/20001
4 years, 5 months ago (2016-07-19 08:20:29 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 08:22:15 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 08:23:09 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca727047837b888b63732d39014d80cae85f7505
Cr-Commit-Position: refs/heads/master@{#37852}

Powered by Google App Engine
This is Rietveld 408576698