Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2159753002:
Do not access member fStop_ variable webrtc::Thread class directly. (Closed)
|
Created:
4 years, 5 months ago by andresp-chromium Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo not check for fStop_ variable in webrtc::Thread.
Committed: https://crrev.com/1a3dee3d5ea0d70977ba5fd79a7d5fa2f74de37f
Cr-Commit-Position: refs/heads/master@{#406388}
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove fStop check #Messages
Total messages: 18 (8 generated)
The CQ bit was checked by andresp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
andresp@chromium.org changed reviewers: + sergeyu@chromium.org, zea@chromium.org
Hi Sergey or Nicolas, please have a look. Had a cl to clean data races on wbertc::Thread reverted due to JingleThreadWrapper using the field directly.
On 2016/07/18 13:50:59, andresp-chromium wrote: > Hi Sergey or Nicolas, please have a look. > > Had a cl to clean data races on wbertc::Thread reverted due to > JingleThreadWrapper using the field directly. That was the cl that was reverted due to breaking chromium: https://codereview.webrtc.org/2135173002/
https://codereview.chromium.org/2159753002/diff/1/jingle/glue/thread_wrapper.cc File jingle/glue/thread_wrapper.cc (right): https://codereview.chromium.org/2159753002/diff/1/jingle/glue/thread_wrapper.... jingle/glue/thread_wrapper.cc:164: if (IsQuitting()) IsQuitting seems to be overriden below to just NOTREACHED(), no?
https://codereview.chromium.org/2159753002/diff/1/jingle/glue/thread_wrapper.cc File jingle/glue/thread_wrapper.cc (right): https://codereview.chromium.org/2159753002/diff/1/jingle/glue/thread_wrapper.... jingle/glue/thread_wrapper.cc:164: if (IsQuitting()) On 2016/07/18 17:40:31, Nicolas Zea wrote: > IsQuitting seems to be overriden below to just NOTREACHED(), no? I think you can just remove these these two lines. fStop_ is always false here.
On 2016/07/18 19:53:06, Sergey Ulanov wrote: > https://codereview.chromium.org/2159753002/diff/1/jingle/glue/thread_wrapper.cc > File jingle/glue/thread_wrapper.cc (right): > > https://codereview.chromium.org/2159753002/diff/1/jingle/glue/thread_wrapper.... > jingle/glue/thread_wrapper.cc:164: if (IsQuitting()) > On 2016/07/18 17:40:31, Nicolas Zea wrote: > > IsQuitting seems to be overriden below to just NOTREACHED(), no? > > I think you can just remove these these two lines. fStop_ is always false here. Done.
Description was changed from ========== Do not access member fStop_ variable webrtc::Thread class directly. ========== to ========== Do not check for fStop_ variable in webrtc::Thread. ==========
lgtm
The CQ bit was checked by andresp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Do not check for fStop_ variable in webrtc::Thread. ========== to ========== Do not check for fStop_ variable in webrtc::Thread. Committed: https://crrev.com/1a3dee3d5ea0d70977ba5fd79a7d5fa2f74de37f Cr-Commit-Position: refs/heads/master@{#406388} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1a3dee3d5ea0d70977ba5fd79a7d5fa2f74de37f Cr-Commit-Position: refs/heads/master@{#406388} |
