Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/objects.cc

Issue 215973004: Remove dead Object::GetPropertyOrFail. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 825 matching lines...) Expand 10 before | Expand all | Expand 10 after
836 Handle<Name> key, 836 Handle<Name> key,
837 PropertyAttributes* attributes) { 837 PropertyAttributes* attributes) {
838 Isolate* isolate = result->isolate(); 838 Isolate* isolate = result->isolate();
839 CALL_HEAP_FUNCTION( 839 CALL_HEAP_FUNCTION(
840 isolate, 840 isolate,
841 object->GetProperty(*receiver, result, *key, attributes), 841 object->GetProperty(*receiver, result, *key, attributes),
842 Object); 842 Object);
843 } 843 }
844 844
845 845
846 MaybeObject* Object::GetPropertyOrFail(Handle<Object> object,
847 Handle<Object> receiver,
848 LookupResult* result,
849 Handle<Name> key,
850 PropertyAttributes* attributes) {
851 Isolate* isolate = result->isolate();
852 CALL_HEAP_FUNCTION_PASS_EXCEPTION(
853 isolate,
854 object->GetProperty(*receiver, result, *key, attributes));
855 }
856
857
858 // TODO(yangguo): handlify this and get rid of. 846 // TODO(yangguo): handlify this and get rid of.
859 MaybeObject* Object::GetProperty(Object* receiver, 847 MaybeObject* Object::GetProperty(Object* receiver,
860 LookupResult* result, 848 LookupResult* result,
861 Name* name, 849 Name* name,
862 PropertyAttributes* attributes) { 850 PropertyAttributes* attributes) {
863 Isolate* isolate = name->GetIsolate(); 851 Isolate* isolate = name->GetIsolate();
864 Heap* heap = isolate->heap(); 852 Heap* heap = isolate->heap();
865 853
866 #ifdef DEBUG 854 #ifdef DEBUG
867 // TODO(mstarzinger): Only because of the AssertNoContextChange, drop as soon 855 // TODO(mstarzinger): Only because of the AssertNoContextChange, drop as soon
(...skipping 15600 matching lines...) Expand 10 before | Expand all | Expand 10 after
16468 #define ERROR_MESSAGES_TEXTS(C, T) T, 16456 #define ERROR_MESSAGES_TEXTS(C, T) T,
16469 static const char* error_messages_[] = { 16457 static const char* error_messages_[] = {
16470 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 16458 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
16471 }; 16459 };
16472 #undef ERROR_MESSAGES_TEXTS 16460 #undef ERROR_MESSAGES_TEXTS
16473 return error_messages_[reason]; 16461 return error_messages_[reason];
16474 } 16462 }
16475 16463
16476 16464
16477 } } // namespace v8::internal 16465 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698