Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2159723003: Change declared variable name in gfx::ScaleTo*Size. (Closed)

Created:
4 years, 5 months ago by jbroman
Modified:
4 years, 5 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change declared variable name in gfx::ScaleTo*Size. Then size is scaled in both axes, so the declared parameter name is confusing. This changes it to "scale", which matches the parameter name in the definition. Committed: https://crrev.com/0f12a3e84399430f9b4f7a9943b676f05881ae07 Cr-Commit-Position: refs/heads/master@{#406065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/gfx/geometry/size.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jbroman
This confused by for a few seconds. PTAL at this trivial fix.
4 years, 5 months ago (2016-07-18 15:06:14 UTC) #3
danakj
LGTM
4 years, 5 months ago (2016-07-18 18:32:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159723003/1
4 years, 5 months ago (2016-07-18 18:34:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 19:36:03 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 19:38:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f12a3e84399430f9b4f7a9943b676f05881ae07
Cr-Commit-Position: refs/heads/master@{#406065}

Powered by Google App Engine
This is Rietveld 408576698