Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2159713002:
Mark PushSubscriptionOptions not in WebView (Closed)
DescriptionMark PushSubscriptionOptions not in WebView
https://codereview.chromium.org/2133673002 added a new
PushSubscriptionOptions interface, but forgot to mark it as not exposed
in WebView (since the Push API is not supported there). Hence that patch
broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch
fixes that.
BUG=626627, 629049
TBR=lizeb@chromium.org,timvolodine@chromium.org
NOTRY=true
Committed: https://crrev.com/dd11513c44ebc8ed0d5da23b9a1b96e17050deea
Cr-Commit-Position: refs/heads/master@{#405976}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
Description was changed from ========== Mark PushSubscriptionOptions not in WebView https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG=626627 ========== to ========== Mark PushSubscriptionOptions not in WebView https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG=626627 TRB=lizeb@chromium.org,timvolodine@chromium.org NOTRY=true ==========
johnme@chromium.org changed reviewers: + lizeb@chromium.org, timvolodine@chromium.org
The CQ bit was checked by johnme@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Mark PushSubscriptionOptions not in WebView https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG=626627 TRB=lizeb@chromium.org,timvolodine@chromium.org NOTRY=true ========== to ========== Mark PushSubscriptionOptions not in WebView https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG=626627 TBR=lizeb@chromium.org,timvolodine@chromium.org NOTRY=true ==========
The CQ bit was checked by johnme@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Mark PushSubscriptionOptions not in WebView https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG=626627 TBR=lizeb@chromium.org,timvolodine@chromium.org NOTRY=true ========== to ========== Mark PushSubscriptionOptions not in WebView https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG=626627,629049 TBR=lizeb@chromium.org,timvolodine@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Description was changed from ========== Mark PushSubscriptionOptions not in WebView https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG=626627,629049 TBR=lizeb@chromium.org,timvolodine@chromium.org NOTRY=true ========== to ========== Mark PushSubscriptionOptions not in WebView https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG=626627,629049 TBR=lizeb@chromium.org,timvolodine@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Mark PushSubscriptionOptions not in WebView https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG=626627,629049 TBR=lizeb@chromium.org,timvolodine@chromium.org NOTRY=true ========== to ========== Mark PushSubscriptionOptions not in WebView https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG=626627,629049 TBR=lizeb@chromium.org,timvolodine@chromium.org NOTRY=true Committed: https://crrev.com/dd11513c44ebc8ed0d5da23b9a1b96e17050deea Cr-Commit-Position: refs/heads/master@{#405976} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/dd11513c44ebc8ed0d5da23b9a1b96e17050deea Cr-Commit-Position: refs/heads/master@{#405976}
Message was sent while issue was closed.
On 2016/07/18 11:40:15, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/dd11513c44ebc8ed0d5da23b9a1b96e17050deea > Cr-Commit-Position: refs/heads/master@{#405976} thanks John! post factum lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
