Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2159683002: [regexp] Fix case-insensitive matching for one-byte subjects. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix case-insensitive matching for one-byte subjects. The bug occurs because we do not canonicalize character class ranges before adding case equivalents. While adding case equivalents, we abort early for one-byte subject strings, assuming that the ranges are sorted. Which they are not. R=marja@chromium.org BUG=v8:5199 Committed: https://crrev.com/a51f429772d1e796744244128c9feeab4c26a854 Cr-Commit-Position: refs/heads/master@{#37833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/regexp/jsregexp.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-5199.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
4 years, 5 months ago (2016-07-18 10:32:06 UTC) #1
marja
lgtm
4 years, 5 months ago (2016-07-18 10:32:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159683002/1
4 years, 5 months ago (2016-07-18 10:36:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 12:03:11 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 12:03:13 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 12:03:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a51f429772d1e796744244128c9feeab4c26a854
Cr-Commit-Position: refs/heads/master@{#37833}

Powered by Google App Engine
This is Rietveld 408576698