third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp - Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: works Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

index fc13b3dc783e4f69ca983d060e51a99e53679f67..9e0818bac6fdef097f16c8cc7ef66fb78eee8774 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

@@ -209,6 +209,11 @@ v8::Local<v8::Value> V8InspectorSessionImpl::findObject(ErrorString* errorString

return objectValue;

}

+std::unique_ptr<protocol::Runtime::Exported::RemoteObject> V8InspectorSessionImpl::wrapObject(v8::Local<v8::Context> context, v8::Local<v8::Value> value, const String16& groupName)

+ return wrapObject(context, value, groupName, false);

std::unique_ptr<protocol::Runtime::RemoteObject> V8InspectorSessionImpl::wrapObject(v8::Local<v8::Context> context, v8::Local<v8::Value> value, const String16& groupName, bool generatePreview)

{

ErrorString errorString;